Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Tactical RMM Widget #1649

Merged
merged 4 commits into from
Aug 17, 2024
Merged

✨ Tactical RMM Widget #1649

merged 4 commits into from
Aug 17, 2024

Conversation

conlan0
Copy link
Contributor

@conlan0 conlan0 commented Jul 25, 2024

conlan0 Medium conlan0 /master → Lissy93/dashy Commits: 4 | Files Changed: 4 | Additions: 264 Label Unchecked Tasks Powered by Pull Request Badge

Category: Feature

Overview
Added Tactical RMM server status widget
This widget uses the built-in monitoring endpoint of a hosted Tactical RMM instance and displays the data returned
to monitor your server's status the widget uses 2 options (url and token) to connect to your server and start displaying the status data.

Also made a slight change to the cors-proxy to send the request body as data instead of json. (I have tested with some widgets to assure no functionality loss but not all widgets)

Screenshot

image

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance

@conlan0 conlan0 requested a review from Lissy93 as a code owner July 25, 2024 20:27
Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 7051aed
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/66a2b527d5ca570008b451ff
😎 Deploy Preview https://deploy-preview-1649--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice! :)

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome!

@Lissy93 Lissy93 merged commit b6668c6 into Lissy93:master Aug 17, 2024
10 checks passed
@CrazyWolf13
Copy link
Collaborator

CrazyWolf13 commented Aug 17, 2024

@Lissy93 Can the useProxy data really just be changed to data without breaking anything?

@Lissy93
Copy link
Owner

Lissy93 commented Aug 17, 2024

Oops, I think you're right. I'm just testing now..
Edit: #1674

@conlan0
Copy link
Contributor Author

conlan0 commented Aug 17, 2024

Thank you i'm glad you like it! i did test data with a few of the other widgets but i dont have all the services needed so i couldnt do all of them but i believe it should work for all because data is the standard in Axios for sending the request body, and using it ensures compatibility with most RESTful APIs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants