Adding order.get_filled_price() and enabling pytest coverage #267

davidlatte · 2023-08-03T22:11:13Z

Main purpose is to add a new function to lumibot.entities.order and provide the testing. As per our agreement, I also added some additional tests to TradingFee to incrementally improve coverage in some other area of the repository.

Side note on coverage

To run coverage:

- Install requirements file:
  pip install -r requirements_dev.txt
- 3 step command to generate a full coverage report
  coverage run
  coverage report
  coverage html
- open the generated ".coverage.html_report/index.html" file in your browser

You will get a coverage report in the terminal that looks like:

And the same data in a nice HTML version:

Back to My code changes

+ New code is all Green -- Fully Covered!

Incremental Coverage Improvement

Sorted by the coverage column!

We now have a fully covered module!! 🎉 🥳

…t unittest coverage.

korbit-ai

The Korbit AI Mentor has reviewed your code. To discuss an issue, reply using the tag @korbit-ai-mentor.

lumibot/entities/order.py

tests/test_tradingfee.py

tests/test_order.py

lumibot/entities/trading_fee.py

Adding order.get_filled_price() and enabling coverage to report pytes…

1715745

…t unittest coverage.

davidlatte linked an issue Aug 3, 2023 that may be closed by this pull request

Order object needs get_filled_price() function. #266

Closed

davidlatte requested a review from grzesir August 3, 2023 22:11