random_album_id = '' causes exception in /gallery in LiveWire #2539
Unanswered
Electro707
asked this question in
Bugs
Replies: 1 comment
-
Hi, thank you for your report. That bug will be gone (hopefully) once I releave v6. Nevertheless, that is an oversight. I think I will need to make a config check in the diagnostics for that one. :/ |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Lychee version
main, +6731535
Which PHP version are you using?
PHP 8.3
Detailed description of the problem
If the config
random_album_id
is set to an empty string, and Livewire is enabled, accessing/gallery/
results in an exception.I have traced the cause down to the
checkFrameAccess
function inLivewire/Components/Pages/Gallery/Albums.php
, where the$randomalbumid
is not checked if it's empty before thefindAbstractAlbumOrFail
is calledI am not familiar enough with the codebase to come up with a good fix myself. I would like to think if the album ID is empty, then frame access is allowed unless there's no image to be shown.
Steps to reproduce the issue
random_album_id
to an empty string ''Diagnostics [REQUIRED]
Browser & System [REQUIRED]
Arch Linux, Firefox
Please confirm (incomplete submissions will not be addressed)
Beta Was this translation helpful? Give feedback.
All reactions