From 38a16a50e9a434f886b4d6d10ea80a215ca4dde7 Mon Sep 17 00:00:00 2001
From: Taku Fukada <naninunenor@gmail.com>
Date: Sun, 28 Jul 2024 01:28:36 +0900
Subject: [PATCH] svelte autodoc: improve jsdoc support

---
 .../svelte-vite/src/plugins/generateDocgen.ts | 28 ++++++++++++-------
 .../DocsJSDocRunes.svelte                     |  4 +--
 .../stories_svelte-kit-skeleton-ts/types.ts   |  5 ++++
 3 files changed, 25 insertions(+), 12 deletions(-)

diff --git a/code/frameworks/svelte-vite/src/plugins/generateDocgen.ts b/code/frameworks/svelte-vite/src/plugins/generateDocgen.ts
index a27584586176..35d828a58d6b 100644
--- a/code/frameworks/svelte-vite/src/plugins/generateDocgen.ts
+++ b/code/frameworks/svelte-vite/src/plugins/generateDocgen.ts
@@ -278,10 +278,11 @@ export function generateDocgen(targetFileName: string, sourceFileCache: SourceFi
           return sourceFileCache.hashToSourceFiles[digest];
         }
 
+        const isTsFile = /<script\s+[^>]*?lang=('|")(ts|typescript)('|")/.test(content);
+
         const tsx = svelte2tsx.svelte2tsx(content, {
           version: VERSION,
-          isTsFile: true,
-          emitOnTemplateError: true,
+          isTsFile: isTsFile,
           mode: 'dts',
         });
 
@@ -290,7 +291,7 @@ export function generateDocgen(targetFileName: string, sourceFileCache: SourceFi
           tsx.code,
           languageVersion,
           true,
-          ts.ScriptKind.JS // Set to 'JS' to enable TypeScript to parse JSDoc.
+          isTsFile ? ts.ScriptKind.TS : ts.ScriptKind.JS // Set to 'JS' to enable TypeScript to parse JSDoc.
         );
 
         sourceFileCache.hashToSourceFiles[digest] = sourceFile;
@@ -363,6 +364,7 @@ export function generateDocgen(targetFileName: string, sourceFileCache: SourceFi
   if (signature && signature.declaration) {
     // Get props type from ReturnType<render>
     const type = checker.getReturnTypeOfSignature(signature);
+
     type.getProperties().forEach((retObjProp) => {
       if (retObjProp.name === 'props') {
         const decl = signature.getDeclaration();
@@ -409,13 +411,18 @@ export function generateDocgen(targetFileName: string, sourceFileCache: SourceFi
     if (ts.isVariableStatement(node)) {
       node.declarationList.declarations.forEach((declaration) => {
         // Extract default values from:
-        //     let { <name> = <defaultValue>, ... }: <propsType> = ...
-        if (
-          propsType &&
-          declaration.type &&
-          propsType === checker.getTypeFromTypeNode(declaration.type) &&
-          ts.isObjectBindingPattern(declaration.name)
-        ) {
+        //     let { <name> = <defaultValue>, ... }: <propsType> = $props();
+
+        const isPropsRune =
+          declaration.initializer &&
+          ts.isCallExpression(declaration.initializer) &&
+          ts.isIdentifier(declaration.initializer.expression) &&
+          declaration.initializer.expression.text === '$props';
+
+        const isPropsType =
+          declaration.type && propsType === checker.getTypeFromTypeNode(declaration.type);
+
+        if (ts.isObjectBindingPattern(declaration.name) && (isPropsRune || isPropsType)) {
           propsRuneUsed = true;
           declaration.name.elements.forEach((element) => {
             const name = element.name.getText();
@@ -438,6 +445,7 @@ export function generateDocgen(targetFileName: string, sourceFileCache: SourceFi
         ) {
           const prop = propMap.get(declaration.name.text);
           if (prop && declaration.initializer) {
+            prop.optional = true;
             const defaultValue = initializerToDefaultValue(declaration.initializer, checker);
             if (defaultValue) {
               prop.defaultValue = defaultValue;
diff --git a/code/frameworks/sveltekit/template/stories_svelte-kit-prerelease-ts/DocsJSDocRunes.svelte b/code/frameworks/sveltekit/template/stories_svelte-kit-prerelease-ts/DocsJSDocRunes.svelte
index f399324da533..f57732f0b5b7 100644
--- a/code/frameworks/sveltekit/template/stories_svelte-kit-prerelease-ts/DocsJSDocRunes.svelte
+++ b/code/frameworks/sveltekit/template/stories_svelte-kit-prerelease-ts/DocsJSDocRunes.svelte
@@ -24,7 +24,7 @@
    * @property {Date=} date Date
    * @property {number | string =} unionTypes Union of types
    * @property {{ a: number } & { b: string } =} intersection Intersection of types
-   * @property {import("svelte").Snippet=} children Snippet contents
+   * @property {import("svelte").Snippet} children Snippet contents
    * @property {(event: MouseEvent) => number =} func Event callback function
    */
 
@@ -52,4 +52,4 @@
   } = $props();
 </script>
 
-<div>Docs: JSDoc + Runes (<code>svelte2tsx@0.7.13</code> does not support this yet.)</div>
+<div>Docs: JSDoc + Runes</div>
diff --git a/code/frameworks/sveltekit/template/stories_svelte-kit-skeleton-ts/types.ts b/code/frameworks/sveltekit/template/stories_svelte-kit-skeleton-ts/types.ts
index dfa3a8f977a7..199b60cbba22 100644
--- a/code/frameworks/sveltekit/template/stories_svelte-kit-skeleton-ts/types.ts
+++ b/code/frameworks/sveltekit/template/stories_svelte-kit-skeleton-ts/types.ts
@@ -1,2 +1,7 @@
 export type LiteralNumbers = 100 | 1000 | 10000;
 export type LiteralStrings = 'apple' | 'grape' | 'orange';
+
+export enum MyEnum {
+  FOO = 'foo',
+  BAR = 'bar',
+}