-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: allow translations #8
Comments
Translations would be great! You can make a fork of this repository and change the text right in the browser. Once you publish on GitHub pages I'll link to it on the original. |
Starting a French translation, if anyone is keen to help with coding let me know, I can just deal with the data |
I think it would be nice to separate content from HTML (so translators don't have to bother with HTML, and translations can benefit from future updates) and have begun work on a mockup of how this could work here. |
I'm going to translate this to european portuguese. There is a good brasilian portuguese translation already, but we treat some number differently. 1 billion is 1 bilhão in Brazil but 1.000 milhões (1.000 millions) in Portugal. |
Already added a Spanish-translated version on #14, which is using static files on another structure, but will definitely help if you decide on going the separate translated files route. The Edit: sorry I misquoted your approach! |
No jquery used, just plain JS 😄 But I agree, it's up to @MKorostoff, I just wanted to make a proof of concept and got a little carried away. I'm willing to go the generator -> static files route if that's what he decides. One of the neat things about separating the content from the HTML is that it's actually not that hard to make the switch. |
@jhoon , I bow out then from the Spanish translation - I am not a web dev and surely I'd be slower doing this. (I'll keep watching in case I can help anyway) |
If you'd like to make a translation, you should do the following:
I'll be happy to link to your translated version from the original. If you have knowledge of web development, you can also clone the repository and fundamentally alter the content to be more relevant to your country, since this is very US centric. I am not going to merge translations back into this repository for the following reasons:
|
I had to find my way here to volunteer writing a Spanish translation. So please make it easier to find you back and to volunteer :)
Great job, by the way!
The text was updated successfully, but these errors were encountered: