Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to rename .jsx.flow -> .js.flow #19

Open
sodiumjoe opened this issue Mar 5, 2019 · 3 comments
Open

option to rename .jsx.flow -> .js.flow #19

sodiumjoe opened this issue Mar 5, 2019 · 3 comments

Comments

@sodiumjoe
Copy link

babel does this, and when I just run flow-copy-source, flow doesn't appear to be able to find the correct files until I rename all the .jsx.flow files to .js.flow.

@sodiumjoe
Copy link
Author

in fact, i can't think of any reason why we'd want .jsx.flow files so maybe an option would be wrong, it should just always rename to .js.flow?

@Macil
Copy link
Owner

Macil commented Mar 6, 2019

This sounds like a good feature. I'm fine with making it the default behavior, though I'm going to consider it a breaking change and bump the major version number.

Should any other extensions be changed to .js? (Like .mjs?) I'd like the default to be consistent with whatever the babel CLI tool does.

@sodiumjoe
Copy link
Author

sodiumjoe commented Mar 6, 2019

I'm not an .mjs user and I'm not sure what the story is for how people use .mjs. I expect for publishing libraries, people still rename to .js, though?

Always renaming to .js seems like a sane default. You could add a configuration option if people need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants