Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA for detecting whether transaction version bump is required #243

Closed
ghzlatarev opened this issue Nov 2, 2021 · 0 comments · Fixed by #475 or #558
Closed

GHA for detecting whether transaction version bump is required #243

ghzlatarev opened this issue Nov 2, 2021 · 0 comments · Fixed by #475 or #558
Assignees
Labels
A-automation Area: Issues and PRs related to Automation A-ci Area: Continuous Integration P-medium Priority: Medium

Comments

@ghzlatarev
Copy link
Contributor

ghzlatarev commented Nov 2, 2021

-The transaction version must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updated.
-This is very hard to determine manually as we're depending on so many pallets from substrate.
-So we should create a GHA to automate the process. The best way to do this is to compare the metadata before and after the changes. Parity has already implemented this so use for reference --> paritytech/polkadot#3631

@ghzlatarev ghzlatarev added A-ci Area: Continuous Integration A-automation Area: Issues and PRs related to Automation labels Jan 11, 2022
@ghzlatarev ghzlatarev changed the title Workflow for detecting whether transaction version bump is required GHA for detecting whether transaction version bump is required Mar 4, 2022
@ghzlatarev ghzlatarev added the P-medium Priority: Medium label Mar 4, 2022
@Dengjianping Dengjianping self-assigned this Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-automation Area: Issues and PRs related to Automation A-ci Area: Continuous Integration P-medium Priority: Medium
Projects
None yet
2 participants