Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error monitoring and error propagation from manta-rs, pallet-assets, pallet-balances in pallet-manta-pay #496

Open
ghzlatarev opened this issue Apr 18, 2022 · 1 comment · Fixed by #519
Open

Better error monitoring and error propagation from manta-rs, pallet-assets, pallet-balances in pallet-manta-pay #496

ghzlatarev opened this issue Apr 18, 2022 · 1 comment · Fixed by #519
Assignees
@ghzlatarev
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one P-medium Priority: Medium P-released Product: already released product related features T-fullstack Team: Relevant for the Fullstack Team
Milestone
Future

Comments

@ghzlatarev
Copy link
Contributor

ghzlatarev commented Apr 18, 2022 •
edited
Loading

For example manta-pay's public_transfer returns generic error message for failures like insufficient funds for existential deposit.
This can be improved.

#977 (comment) Otherwise we can't really do monitoring of unexpected errors that break the ledger.
@ghzlatarev ghzlatarev self-assigned this Apr 19, 2022
@ghzlatarev ghzlatarev mentioned this issue Apr 28, 2022
Merged
10 tasks
@ghzlatarev ghzlatarev reopened this May 4, 2022
@ghzlatarev
Copy link
Contributor Author

Needs paritytech/substrate#10242 in 0.9.19 upgrade

@ghzlatarev ghzlatarev added this to the v3.3.0 milestone Jul 15, 2022
@ghzlatarev ghzlatarev added the P-medium Priority: Medium label Jul 15, 2022
@stechu stechu modified the milestones: v3.3.0, v3.4.0 Jul 18, 2022
@ghzlatarev ghzlatarev modified the milestones: v3.4.0, Future Aug 29, 2022
@ghzlatarev ghzlatarev changed the title Better error message propagation from pallet-assets, pallet-balances in pallet-manta-pay Better error message propagation from manta-rs, pallet-assets, pallet-balances in pallet-manta-pay Jan 16, 2023
@ghzlatarev ghzlatarev mentioned this issue Jan 16, 2023
Merged
5 tasks
@ghzlatarev ghzlatarev changed the title Better error message propagation from manta-rs, pallet-assets, pallet-balances in pallet-manta-pay Better error monitoring and error propagation from manta-rs, pallet-assets, pallet-balances in pallet-manta-pay Jan 16, 2023
@ghzlatarev ghzlatarev added P-released Product: already released product related features T-fullstack Team: Relevant for the Fullstack Team C-enhancement Category: An issue proposing an enhancement or a PR with one labels Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghzlatarev ghzlatarev

Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one P-medium Priority: Medium P-released Product: already released product related features T-fullstack Team: Relevant for the Fullstack Team
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Concrete fungible ledger integration tests Manta-Network/Manta
2 participants
@stechu @ghzlatarev