Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the "sealed" really necessary? #35

Closed
Leh2 opened this issue Apr 24, 2015 · 1 comment
Closed

Is the "sealed" really necessary? #35

Leh2 opened this issue Apr 24, 2015 · 1 comment

Comments

@Leh2
Copy link

Leh2 commented Apr 24, 2015

I would love to extend attributes like FieldAlignAttribute to match my current requirements and to avoid repeating [FieldAlign(AlignMode.Right, '0')].

I could imagine the reason for using sealed is about performance, but are there really any significant gains, to justify the removal of extensibility?

If there are other reasons I haven't thought of, please enlighten me :)

@MarcosMeli
Copy link
Owner

Hi there

All attributes are marked as sealed because the library knows how to work with them, if you inherit from it and add extra info it don't get used

But thinking in your scenario, is completely right to create a FieldAlignRightWithZero() and call the constructor of the FieldAlignAtrribute

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants