Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README needs correction for permissions #18

Open
TonyGravagno opened this issue Apr 30, 2023 · 2 comments
Open

README needs correction for permissions #18

TonyGravagno opened this issue Apr 30, 2023 · 2 comments
Labels
bug

Comments

@TonyGravagno
Copy link

I appreciate the PR for the README regarding permissions. However, if we just update permissions.yml as documented now the following error results on server startup:

ERROR]: Permission in permissions.yml was already defined
java.lang.IllegalArgumentException: The permission eternallight.target is already defined!

I can look at this if required. Anyone else?
@Masstrix Masstrix added the bug label May 7, 2023
@Masstrix
Copy link
Owner

Masstrix commented May 7, 2023

Honestly permissions have always been a bit funky and people seemed to struggle with them or they often broke with previous versions. It's quite possibly the way I implemented permissions in the plugin as I always used my own "permission" system for my personal plugins in the past.

Something to that can be looked into at some point.

@TonyGravagno
Copy link
Author

Linking with #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TonyGravagno @Masstrix