Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right to Left Bugs - Combobox Control #1184

Closed
AmRo045 opened this issue Feb 3, 2019 · 6 comments
Closed

Right to Left Bugs - Combobox Control #1184

AmRo045 opened this issue Feb 3, 2019 · 6 comments

Comments

@AmRo045
Copy link
Contributor

AmRo045 commented Feb 3, 2019

The material design ComboBox control not work properly in RTL direction
How can i fix this?
Material Desing Combobox Control Issue

@ahmed-abdelrazek
Copy link
Contributor

i can't reproduce this with the latest commit from the master branch in the demo project could you create a test repository with the problem

image

image

@AmRo045
Copy link
Contributor Author

AmRo045 commented Feb 5, 2019

I create a repository to reproduce this issue:

Sample Repository

Preview:

Image

@jespersh
Copy link
Contributor

jespersh commented Feb 5, 2019

Please try with the master branch on here. Seeing your packages.config is version 2.5.0.1205

@ahmed-abdelrazek
Copy link
Contributor

ahmed-abdelrazek commented Feb 5, 2019

Please try with the master branch on here. Seeing your packages.config is version 2.5.0.1205

it also happens with the latest commit from the master and i think it happens because the first item (or selected one ) in the drop down list is empty with Transparent background to show what's behind it in the combobox

image

untitled

image
that why you only notice it when it have a different element with a different color behind it like your desktop background etc when it expand out of your app border or on another controller

sorry but i have to say it
it's a feature not a bug

@Keboo
Copy link
Member

Keboo commented Feb 10, 2019

@AmRo045 thank you for the repo project.
I am not able to reproduce your exact issue but there is some issues here that should be addressed.

Reproduction steps (works on latest demo app as well)

  1. Set FlowDirection="RightToLeft" on the window.
  2. Set FlowDirection="LeftToRight" on the ComboBox

Observed: The selected item disappears from view when the ComboBox's popup is open.
rtl

After a little digging it appears the issues is with the ComboBoxPopup.VisiblePlacementWidth getting set to 0. It appears that the hit testing being down is making some assumptions about the flow direction and needs to be updated to properly handle this case.

@Madcheese101
Copy link

@AmRo045 thank you for the repo project.
I am not able to reproduce your exact issue but there is some issues here that should be addressed.

Reproduction steps (works on latest demo app as well)

  1. Set FlowDirection="RightToLeft" on the window.
  2. Set FlowDirection="LeftToRight" on the ComboBox

Observed: The selected item disappears from view when the ComboBox's popup is open.
rtl

After a little digging it appears the issues is with the ComboBoxPopup.VisiblePlacementWidth getting set to 0. It appears that the hit testing being down is making some assumptions about the flow direction and needs to be updated to properly handle this case.

unfortunately this problem just occurred to me in the latest version and the fix you provided in your last comment did not work for me at all :'(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants