Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usages of .Tag on ComboBox theme #147

Closed
2 tasks
ButchersBoy opened this issue Dec 1, 2015 · 4 comments
Closed
2 tasks

Remove usages of .Tag on ComboBox theme #147

ButchersBoy opened this issue Dec 1, 2015 · 4 comments

Comments

@ButchersBoy
Copy link
Collaborator

  • ComboBox theme (ComboBoxItem.Tag)
  • Also, TreeView theme, but lower priority as on more of a hidden element.

Should remove this as we are blocking people from using .Tag for their own purposes, and replace with an attached property.

Either:

  • Add
    • ComboBoxAssist.HideItem : bool
    • TreeViewAssist.HeightFactor : double
  • Or a single MaterialDesign.FrameworkTag : object

I think I prefer the former, more verbose option, even though it creates more classes...

@l1pton17
Copy link
Contributor

But treeview uses inner scrollviewer's tag, that is not a part of open properties.
I mean template doesn't use TreeViewItem.Tag.

@ButchersBoy
Copy link
Collaborator Author

Sorry, my mistake...

But did you see #159 ?

@l1pton17
Copy link
Contributor

@ButchersBoy yes, i will fix it in a few days

@ButchersBoy
Copy link
Collaborator Author

Cool, thanks, I'll mark as in progress and leave to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants