Fix 3593: Double up the space reserved for the Clip #3594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3593
Not the nicest of fixes, but I can't really explain why the
ActualHeightis not sufficient.My initial thought was that it was DPI-scaling that needed to be taken into account, but this was also reproduceable when setting the DPI scaling to 100% (i.e. no scaling).
The poor mans solution was to simply double up the reserved space. If you have a better fix, please just abandon this PR. For now I just want the hints to not be clipped "by default" which they are right now. Basically anything below the baseline of the text is currently clipped.