Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response encryption with SSL #14

Closed
jeremylvln opened this issue Feb 11, 2020 · 2 comments
Closed

Response encryption with SSL #14

jeremylvln opened this issue Feb 11, 2020 · 2 comments

Comments

@jeremylvln
Copy link
Contributor

We should expose the raw file descriptor to the modules to permits encryption/decryption. Actually, only the server has the information.

@MatthieuMv
Copy link
Owner

Now it's fixed, I also removed the useless "encryption key" in Packet class.

@MatthieuMv
Copy link
Owner

Please notice that I added "onConnection" && "onDisconnection" callbacks for each modules (as dedicated virtual functions) to let you add more socket specific modules in your project.
All you need to do it derive theses function and call the Pipeline::onConnection/onDisconnection triggers functions to notify modules of any changes.
I'm currently updated md files to explain how it should be integrated.

If you think that you may need another change to implement SSL or any other specific modules, please tell me what you could need, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants