Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: MetaMask/core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v25.1.0
Choose a base ref
...
head repository: MetaMask/core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v26.0.0
Choose a head ref
  • 14 commits
  • 53 files changed
  • 14 contributors

Commits on Jan 24, 2022

  1. 25.1.0 (#679)

    Co-authored-by: github-actions <github-actions@github.com>
    Co-authored-by: Brad Decker <git@braddecker.dev>
    3 people committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    65f2cd0 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2022

  1. Upgrade eth-abi-module (#681)

    Gustavo Antunes committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    81bcbae View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2022

  1. Bump ajv from 6.10.2 to 6.12.6 (#690)

    Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.10.2 to 6.12.6.
    - [Release notes](https://github.com/ajv-validator/ajv/releases)
    - [Commits](ajv-validator/ajv@v6.10.2...v6.12.6)
    
    ---
    updated-dependencies:
    - dependency-name: ajv
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    3fdd55e View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2022

  1. Configuration menu
    Copy the full SHA
    792d86c View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2022

  1. Migrate PermissionController and SubjectMetadataController (#692)

    * Initial copy-paste
    
    * Fix a bunch of imports etc
    
    * Fix some typing issues
    
    * Fix another type issue
    
    * Fix linting issues + add missing doc strings
    
    * Run Prettier on README
    
    * Fix some test typing issues + ignore others
    
    * Revert a recent change
    
    * Remove unused function
    
    * Remove remains of bold formatting
    
    * Fix usage of messengers to improve test typing
    
    * Fix some issues with JSDocs
    
    * Add util function tests
    
    * Use @metamask/types for a bunch of shared types
    
    * Fix a few import issues
    
    * Remove unnecessary ts-expect-error comments
    FrederikBolding committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    89c0050 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2022

  1. Expose WebSocket for network access (#696)

    * Expose XMLHttpRequest for network access endowment
    
    * Add WebSocket
    
    * Fix linting
    
    * Remove XmlHttpRequest since its not available in Node.js
    FrederikBolding committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    e8598c3 View commit details
    Browse the repository at this point in the history
  2. **BREAKING**: Fetch and return token image as part of getDetails ca…

    …lls on ERC721Standard and ERC1155Standard (#702)
    
    * Fetch and return token image as part of getDetails call
    
    * adapt tests
    adonesky1 committed Mar 3, 2022
    1 Configuration menu
    Copy the full SHA
    613c5b9 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2022

  1. Add RateLimitController (#698)

    * Initial implementation of NotificationControllerV2
    
    * Simplify implementation
    
    * Fix small type issue
    
    * Simplify and start using messaging system
    
    * Adapt tests for controller messaging
    
    * Simplify tests a bit
    
    * Add action handler
    
    * Fix types
    
    * Fix tests
    
    * Add some documentation and exports
    
    * Pivot to RateLimitController
    
    * Fix export
    
    * Remove subject metadata type
    
    * Make controller generic and allow caller to pass implementation mapping
    
    * Fix PR comments
    
    * Fix type name casing
    
    * Fix controller docstrings
    
    The docstrings contained references to "notifications" from this controller's infancy.
    
    * Return potential result from implementation, Wrap in promise in case implementation is async
    
    * Improve typing and API
    
    * Fix type issue
    
    * Fix PR comments
    
    * Cast action handler
    
    * Change use of useFakeTimers
    
    * Throw error when API is rate-limited
    
    * Small fixes
    
    Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
    FrederikBolding and rekmarks committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    9c5b75a View commit details
    Browse the repository at this point in the history
  2. Reduce load on Infura in gas estimate fallback (#705)

    Usually we use the MetaSwap API for gas fee estimates, but if that is
    down for some reason, we fall back to hitting Infura directly.
    
    A little while ago we were working on some UI improvements to the
    extension around gas fees, and to support this some changes to the
    MetaSwap API were made so that it requests the last 20,000 blocks from
    the network and uses their data to obtain a baseline for base fees so
    that we can display a network stability/congestion meter.
    
    We made the same changes to the gas fee estimation fallback logic.
    **This ended up being a very bad decision.** Because none of the the
    requests to Infura that the fallback logic makes are cached, when the
    MetaSwap API goes down, the number of requests made to Infura
    skyrockets and Infura suffers performance-wise. This problem already
    existed, but has been severely exacerbated by the new changes to the
    fallback logic. In fact, recently the Infura team had to disable the
    `eth_feeHistory` endpoint because some of the Ethereum nodes crashed
    under all of the load.
    
    To address this, this commit updates the part of the fallback logic
    which is responsible for calculating network congestion to always return
    0.5 instead of making the aforementioned 20,000-block request. This
    means that the network stability meter in the extension will stay
    static, but that is absolutely preferable to blasting Infura.
    mcmire committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    ee93293 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2022

  1. [GasController] Check for undefined basefeePerGas (#703)

    go-ethereum based chains never return empty baseFeePerGas because this is omitted in the serializer:
    
    ```
    type feeHistoryResult struct {
    	OldestBlock  *hexutil.Big     `json:"oldestBlock"`
    	Reward       [][]*hexutil.Big `json:"reward,omitempty"`
    	BaseFee      []*hexutil.Big   `json:"baseFeePerGas,omitempty"` <---
    	GasUsedRatio []float64        `json:"gasUsedRatio"`
    }
    ```
    
    Current code checks for baseFeePerGas.length > 0 without checking for the occurence of this element.
    This leads to an exception and in later flow to fallback to eth_gasPrice mode
    
    FIXED: no feeMarket mode available in case one of past requests return no results
    peak3d committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    777f5da View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2022

  1. [FeeHistory] Allow test chains with few blocks (#699)

    The (gas)controller requests 20.000 long range results when opening the FeeMarket.
    New chains / test chains normally don't have that amount of blocks, and in this case the controller requests feeHistory with a wrong hex value (0x-4756) which pollutes the node logs.
    
    Beside this such a chain can return fewer results than requested, the current code doesn't handle this case correctly when analyzing feeHistory results. This leads to fallback to eth_gas mode.
    
    FIXED: (Gas)Controller does not detect FeeMarket mode for test chains, even the chain supports EIP1559.
    peak3d committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    eaba91f View commit details
    Browse the repository at this point in the history
  2. Added revokePermissions to PermissionController actions (#708)

    * Added revokePermissions to PermissionController actions
    
    Co-authored-by: Hassan Malik <41640681+hmalik88@users.noreply.github.com>
    Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
    3 people committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    477ee49 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2022

  1. Fix coverage glob (#714)

    * Fix coverage glob
    
    * Reduce coverage thresholds for now
    
    * Simplify glob slightly
    
    Co-authored-by: Mark Stacey <markjstacey@gmail.com>
    FrederikBolding and Gudahtt committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    d394467 View commit details
    Browse the repository at this point in the history
  2. 26.0.0 (#711)

    * 26.0.0
    
    * Update changelog
    
    Co-authored-by: github-actions <github-actions@github.com>
    Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
    Co-authored-by: Alex <adonesky@gmail.com>
    Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
    5 people committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    a799f42 View commit details
    Browse the repository at this point in the history
Loading