Remove If-None-Match header from phishing config requests #277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #256
This PR removes the
If-None-Match
header from the requests for the phishing list. The header was a holder from the old implementation that used GitHub's content API (#232) and is no longer needed. (The header also caused the request to fail when a UA enforcedAccess-Control-Allow-Headers
, which is missing on the jsDelivr response.)Removing this header reverts the fetch cache mode to
default
:As a result the browser will take care of the conditional network fetch.
This—as a bonus—removes the CORS preflight request as there are no custom options anymore.