Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AbstractMessageManager error #367

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Feb 25, 2021

The error thrown when trying to set the status of a non-existent message was broken. The first variable in the error message resolved to undefined. It has been updated to reference the type of the controller that threw the error.

The error thrown when trying to set the status of a non-existent
message was broken. The first variable in the error message resolved to
`undefined`. It has been updated to reference the type of the
controller that threw the error.
@Gudahtt Gudahtt requested a review from a team as a code owner February 25, 2021 18:14
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit eeac8ec into develop Feb 25, 2021
@Gudahtt Gudahtt deleted the fix-abstract-message-manager-error branch February 25, 2021 19:13
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
The error thrown when trying to set the status of a non-existent
message was broken. The first variable in the error message resolved to
`undefined`. It has been updated to reference the type of the
controller that threw the error.
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
The error thrown when trying to set the status of a non-existent
message was broken. The first variable in the error message resolved to
`undefined`. It has been updated to reference the type of the
controller that threw the error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants