Use "options bag" for BaseControllerV2 constructor #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
use-options-bag-for-base-controller-v2-constructor
branch
from
ab539df
to
f17a741
Compare
The BaseControllerV2 constructor now uses an options bag for parameters instead of positional parameters. This improves the readability of the constructor, making it easier to tell what each parameter is for.
Gudahtt
force-pushed
the
use-options-bag-for-base-controller-v2-constructor
branch
from
f17a741
to
9bc3d11
Compare
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The BaseControllerV2 constructor now uses an options bag for parameters instead of positional parameters. This improves the readability of the constructor, making it easier to tell what each parameter is for.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The BaseControllerV2 constructor now uses an options bag for parameters instead of positional parameters. This improves the readability of the constructor, making it easier to tell what each parameter is for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BaseControllerV2 constructor now uses an options bag for parameters instead of positional parameters. This improves the readability of the constructor, making it easier to tell what each parameter is for.