Add EIP1559 support including speedUpTransaction and stopTransaction
#521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
force-pushed
the
eip1559-speed-up
branch
2 times, most recently
from
1a73aa6
to
46fa85b
Compare
Closed
rickycodes
changed the title
speedUpTransaction and stopTransaction
rickycodes
force-pushed
the
eip1559-speed-up
branch
from
d70be0c
to
bc89279
Compare
rickycodes
changed the title
speedUpTransaction and stopTransactionspeedUpTransaction and stopTransaction
rickycodes
force-pushed
the
eip1559-speed-up
branch
from
a6a0886
to
a91df53
Compare
adonesky1
reviewed
Jul 21, 2021
adonesky1
reviewed
Jul 21, 2021
adonesky1
previously approved these changes
Jul 21, 2021
There was a problem hiding this comment.
LGTM. But @brad-decker or @darkwing could either of you take a look as well?
darkwing
reviewed
Jul 22, 2021
darkwing
reviewed
Jul 22, 2021
darkwing
approved these changes
Jul 23, 2021
Merged
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…on` (#521) Co-authored-by: andrepimenta <andrepimenta7@gmail.com> Co-authored-by: Alex Donesky <adonesky@gmail.com>
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…on` (#521) Co-authored-by: andrepimenta <andrepimenta7@gmail.com> Co-authored-by: Alex Donesky <adonesky@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EIP1559 functionality including speedUp and cancel.
This still needs to be updated with main, but I am going to move it out of Draft now as I think it's ready for initial review.