Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING: ERC1155 support #615

Merged
merged 43 commits into from
Oct 28, 2021
Merged

BREAKING: ERC1155 support #615

merged 43 commits into from
Oct 28, 2021

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Oct 15, 2021 •
edited
Loading

Description

Currently we don't support the collectible standard ERC-1155, the focus of this development is to integrated the ERC-1155 ABI to access the appropriate methods of the smart contract.

Breaking Changes

  • CollectiblesController: Consumers of the CollectiblesController will have to update the creation parameters and initialization of the object created. The parameters are:
    • AssetsContractController.getOwnerOf
    • AssetsContractController.balanceOfERC1155Collectible
    • AssetsContractController.uriERC1155Collectible

To Do

  • Add ERC-1155 ABI dependence.
  • Develop classes to represent ERC-721 and ERC-1155.
  • Update the AssetsContractController to handle the new standard.
  • Update the CollectiblesController to verify the ownership of any of the mentioned standards.
  • Update testing and docs.

Next Steps

  • Develop class to represent ERC-20
  • Move the smart contracts ABI (ERC-20, ERC-721, and ERC-1155) to a MM repository.

@gantunesr gantunesr requested a review from a team as a code owner October 15, 2021 13:38
@Gudahtt
Copy link
Member

Gudahtt commented Oct 15, 2021

Could you add a description for these changes?

@gantunesr
Copy link
Member Author

Hey @Gudahtt! Yes! I just found out some testing updates, I will fix that and update the PR for review

sethkfman
sethkfman reviewed Oct 19, 2021
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments and clarifications

src/assets/CollectiblesController.ts Show resolved Hide resolved
src/assets/CollectiblesController.ts Outdated Show resolved Hide resolved
src/assets/CollectibleStandards/ERC1155/ERC1155Standard.ts Outdated Show resolved Hide resolved
src/assets/CollectibleStandards/ERC1155/ERC1155Standard.ts Outdated Show resolved Hide resolved
adonesky1
adonesky1 reviewed Oct 27, 2021
View reviewed changes
src/constants.ts Outdated Show resolved Hide resolved
adonesky1
adonesky1 requested changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few questions! Great work though!

sethkfman
sethkfman previously approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adonesky1
Copy link
Contributor

Just a few tiny nits and then looks good to go!

adonesky1
adonesky1 approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gantunesr gantunesr merged commit a87d2a0 into main Oct 28, 2021
@gantunesr gantunesr deleted the feat/erc1155 branch October 28, 2021 17:32
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@MajorLift
BREAKING: ERC1155 support (#615)
c0d9a44 
Enhancement to support ERC1155 collectible standard by adding the smart contract ABI.
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@MajorLift
BREAKING: ERC1155 support (#615)
1c31ad7 
Enhancement to support ERC1155 collectible standard by adding the smart contract ABI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adonesky1 adonesky1 adonesky1 approved these changes

@wachunei wachunei Awaiting requested review from wachunei

@sethkfman sethkfman Awaiting requested review from sethkfman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gantunesr @Gudahtt @sethkfman @adonesky1 @wachunei