Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add openSeaEnabled preference #645

Merged
merged 4 commits into from
Nov 30, 2021
Merged

add openSeaEnabled preference #645

merged 4 commits into from
Nov 30, 2021

Conversation

adonesky1
Copy link
Contributor

  • BREAKING:

    • openSeaEnabled preference is introduced and defaulted to false on the preferencesController. This value is used to determine whether the collectiblesController makes use of OpenSea's API for fetching collectible data.
      • Consumers who use the collectibleDetectionController and collectibleController who wish to continue use of OpenSea's API will either need to configure openSeaEnabled to true after instantiating the controller now or expose a toggle for users to change the openSeaEnabled state in the preferences controller.

  • FIXED:

@adonesky1 adonesky1 requested a review from a team as a code owner November 30, 2021 19:00
@wachunei wachunei mentioned this pull request Nov 30, 2021
Merged
4 tasks
@adonesky1 adonesky1 merged commit dd23b43 into main Nov 30, 2021
@adonesky1 adonesky1 deleted the opensea-enabled-preference branch November 30, 2021 20:30
@adonesky1 adonesky1 mentioned this pull request Nov 30, 2021
Merged
@gantunesr gantunesr mentioned this pull request Dec 3, 2021
Closed
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@adonesky1 @MajorLift
add openSeaEnabled preference (#645)
fe7fb46 
* add openSeaEnabled preference

* stop polling when useCollectibleDetection set to false, set useCollectibleDetection to false when openSeaEnabled set to false

* cleanup

* update tests
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@adonesky1 @MajorLift
add openSeaEnabled preference (#645)
12de710 
* add openSeaEnabled preference

* stop polling when useCollectibleDetection set to false, set useCollectibleDetection to false when openSeaEnabled set to false

* cleanup

* update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wachunei wachunei wachunei approved these changes

@gantunesr gantunesr Awaiting requested review from gantunesr

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adonesky1 @wachunei