adapting new collectiblesController shape #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adonesky1
commented
Dec 1, 2021
adonesky1
commented
- FIXED:
- Fix issue where chainId is formatted differently in manual collectible add and detection add flows.
adonesky1
force-pushed
the
chainId-hotfix
branch
from
be47642
to
a1c47b8
Compare
danjm
reviewed
Dec 1, 2021
src/assets/CollectiblesController.ts
Outdated
| @@ -489,6 +490,13 @@ export class CollectiblesController extends BaseController< | |||
| selectedAddress = detection.userAddress; | |||
| } else { | |||
| chainId = this.config.chainId; | |||
|
|
|||
There was a problem hiding this comment.
Place this outstide the if/else block, so that the chainId set in the if block is covered as well, in case it is not properly formatted
adonesky1
force-pushed
the
chainId-hotfix
branch
from
a08a94a
to
721ca51
Compare
This was referenced Dec 1, 2021
Merged
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* adapting new collectiblesController shape * address feedback
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* adapting new collectiblesController shape * address feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.