Make getTokenStandardAndDetails function signature reflect that the second arg is optional #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…econd arg is optional
adonesky1
force-pushed
the
make-arg-optional
branch
from
97d9f9b
to
e325355
Compare
mcmire
approved these changes
Mar 10, 2022
There was a problem hiding this comment.
If we're going to do this it would be nice if getTokenStandardAndDetails took an object rather than positional arguments. Otherwise people will have to say getTokenStandardAndDetails('some token address', null, 'some token id') if they aren't interested in passing userAddress. But, I guess we'd have to issue another breaking change, so I'm good with this.
Agreed. Lets make the function take an object in a later PR and pull it into a release that will already contain breaking changes maybe? @mcmire |
|
@adonesky1 Yup sounds good! |
soralit
pushed a commit
to KeystoneHQ/controllers
that referenced
this pull request
Mar 14, 2022
…econd arg is optional (MetaMask#717)
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…econd arg is optional (#717)
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…econd arg is optional (#717)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGED:
getTokenStandardAndDetailsfunction signature reflect that the second arg is optional. Consumers of this method can continue to pass theuserAddressas a second option if they are wanting to query for the user balance of an ERC20 token.