bump @keystonehq/metamask-airgapped-keyring to latest version #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brad-decker
approved these changes
Sep 21, 2022
gantunesr
pushed a commit
that referenced
this pull request
Dec 8, 2022
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keystone team graciously upgrade the version of ethereumjs-util that they use in bc-ur-registry-eth and metamask-airgapped-keyring, per our request.
Since this upgrade bumps us several minor versions we should do a thorough test of the Keystone integration as part of the QA for this PR.
Background context:
We're currently trying to trim down our bundle size and as part of that effort we're attempting to replace the heavy secp256k1-node implementation out of our dependency graph with the @noble/secp256k1 implementation. Currently metamask-airgapped-keyring depends on base-eth-keyring & bc-ur-registry-eth which both use ethereumjs-util version 7.0.8 which depends on an old version of ethereum-cryptography which depends on the heavier implementation. The keystone team has bumped ethereumjs-util to the latest version 8.0.0 (package name is changed to @ethereumjs/util ) in these packages, so it now depends on a newer version of ethereum-cryptography which uses the noble implementation.