-
-
Notifications
You must be signed in to change notification settings - Fork 178
Comparing changes
Open a pull request
base repository: MetaMask/core
base: @metamask/approval-controller@1.0.0
head repository: MetaMask/core
compare: @metamask/approval-controller@1.0.1
- 11 commits
- 65 files changed
- 8 contributors
Commits on Nov 22, 2022
-
Fix race condition where some token detections can get mistakenly add…
…ed to the wrong account (#956) Fix race condition causing misattribution for token-detection across networks and accounts
Configuration menu - View commit details
-
Copy full SHA for 3454eeb - Browse repository at this point
Copy the full SHA 3454eebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4dbce9e - Browse repository at this point
Copy the full SHA 4dbce9eView commit details
Commits on Nov 23, 2022
-
Export action and event handler types (#987)
The `ActionHandler`, `EventHandler` and related types were previously not exported. We use these in `snaps-monorepo`, but currently have to copy them over.
Configuration menu - View commit details
-
Copy full SHA for fe822ff - Browse repository at this point
Copy the full SHA fe822ffView commit details
Commits on Nov 24, 2022
-
Add commit message filter for release check (#983)
A check has been added to the `is-release` job to ensure that the commit message looks the way we expect it to. This acts as protection against accidentally triggering the release workflow.
Configuration menu - View commit details
-
Copy full SHA for bbc4327 - Browse repository at this point
Copy the full SHA bbc4327View commit details
Commits on Nov 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a3d6492 - Browse repository at this point
Copy the full SHA a3d6492View commit details -
Add lastFetched PhishingController state (#986)
**Pass in initial state to PhishingController and load the initialState from persisted state** In Manifest V3, there's need to 1. Persist phishingcontroller state 2. Load phishingcontroller from persistent state Thos PR makes sure state is loaded from persistent state and also abstracts out the checks required before updating the lists - BREAKING: - All the code bases using PhishingController should continue to work as expected - CHANGED: - We should call initialise before calling PhishingDetector controller. - ADDED: - Added `maybeUpdatePhishingLists` method so that controllers don't have to do the check logic anymore **Checklist** - [ ] Tests are included if applicable - [ ] Any added code is fully documented **Issue** Resolves MetaMask/metamask-extension#16551 Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5f1f69d - Browse repository at this point
Copy the full SHA 5f1f69dView commit details
Commits on Dec 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 55c30e2 - Browse repository at this point
Copy the full SHA 55c30e2View commit details -
Fix link for assets-controllers (#997)
Will committedDec 1, 2022 Configuration menu - View commit details
-
Copy full SHA for f49fd49 - Browse repository at this point
Copy the full SHA f49fd49View commit details -
Relax inter-monorepo dependencies (#998)
Switch all `workspace:` dependencies from `~` to `^`. This should help to reduce dependency churn and duplication in other projects.
Configuration menu - View commit details
-
Copy full SHA for 6777d2c - Browse repository at this point
Copy the full SHA 6777d2cView commit details -
Expand contributor docs (#993)
The monorepo works differently than other repos, and we want to make sure that contributors are able to use it on their own: * The release process is different than other repos because it makes use of `create-release-branch` rather than the `create-release-pr` action. * Performing tasks (running tests, etc.) across the monorepo is different than with other repos because it takes advantage of workspaces. * Testing changes made to the monorepo in other projects is different because of the use of preview builds. This commit moves the existing contributor documentation which was formerly present in the README to a separate file and adds some more sections. Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8e5039a - Browse repository at this point
Copy the full SHA 8e5039aView commit details
Commits on Dec 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4de13fe - Browse repository at this point
Copy the full SHA 4de13feView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff @metamask/approval-controller@1.0.0...@metamask/approval-controller@1.0.1