Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: MetaMask/core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: @metamask/approval-controller@1.0.0
Choose a base ref
...
head repository: MetaMask/core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: @metamask/approval-controller@1.0.1
Choose a head ref
  • 11 commits
  • 65 files changed
  • 8 contributors

Commits on Nov 22, 2022

  1. Fix race condition where some token detections can get mistakenly add…

    …ed to the wrong account (#956)
    
    Fix race condition causing misattribution for token-detection across networks and accounts
    adonesky1 committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    3454eeb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4dbce9e View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. Export action and event handler types (#987)

    The `ActionHandler`, `EventHandler` and related types were previously
    not exported. We use these in `snaps-monorepo`, but currently have to
    copy them over.
    Mrtenz committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    fe822ff View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2022

  1. Add commit message filter for release check (#983)

    A check has been added to the `is-release` job to ensure that the commit
    message looks the way we expect it to. This acts as protection against
    accidentally triggering the release workflow.
    Gudahtt committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    bbc4327 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. Release 35.0.0 (#990)

    hmalik88 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    a3d6492 View commit details
    Browse the repository at this point in the history
  2. Add lastFetched PhishingController state (#986)

    **Pass in initial state to PhishingController and load the initialState
    from persisted state**
    In Manifest V3, there's need to 
    
    1. Persist phishingcontroller state
    2. Load phishingcontroller from persistent state
    
    Thos PR makes sure state is loaded from persistent state and also
    abstracts out the checks required before updating the lists
    
    - BREAKING:
    - All the code bases using PhishingController should continue to work as
    expected
    - CHANGED:
    - We should call initialise before calling PhishingDetector controller.
    
    - ADDED:
    
    - Added `maybeUpdatePhishingLists` method so that controllers don't have
    to do the check logic anymore
    
    **Checklist**
    
    - [ ] Tests are included if applicable
    - [ ] Any added code is fully documented
    
    **Issue**
    
    Resolves MetaMask/metamask-extension#16551
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    segun committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    5f1f69d View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2022

  1. Configuration menu
    Copy the full SHA
    55c30e2 View commit details
    Browse the repository at this point in the history
  2. Fix link for assets-controllers (#997)

    Will committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    f49fd49 View commit details
    Browse the repository at this point in the history
  3. Relax inter-monorepo dependencies (#998)

    Switch all `workspace:` dependencies from `~` to `^`. This should help
    to reduce dependency churn and duplication in other projects.
    mcmire committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    6777d2c View commit details
    Browse the repository at this point in the history
  4. Expand contributor docs (#993)

    The monorepo works differently than other repos, and we want to make
    sure that contributors are able to use it on their own:
    
    * The release process is different than other repos because it makes use
    of `create-release-branch` rather than the `create-release-pr` action.
    * Performing tasks (running tests, etc.) across the monorepo is
    different than with other repos because it takes advantage of
    workspaces.
    * Testing changes made to the monorepo in other projects is different
    because of the use of preview builds.
    
    This commit moves the existing contributor documentation which was
    formerly present in the README to a separate file and adds some more
    sections.
    
    Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
    Co-authored-by: Mark Stacey <markjstacey@gmail.com>
    3 people committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    8e5039a View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2022

  1. Release 36.0.0 (#999)

    mcmire committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    4de13fe View commit details
    Browse the repository at this point in the history
Loading