getDetails method in ERC721Standard and ERC1155Standard classes should return image/description instead of TokenURI

[adonesky1]

The getDetails methods for ERC721Standard and ERC1155Standard currently fetch and return a tokenURI. Ideally they would fetch the tokenURI and then use it to fetch other more useful details like image name and description (possibly more) as we do in the getCollectibleInformationFromTokenURI method of the CollectiblesController.

[adonesky1]

cc @gantunesr @wachunei, tagging you both for thoughts/visibility.

[wachunei]

sounds right, getTokenURI should return the UR and getDetails should resolve it.
I'm thinking about the case the tokenURI is a data URI, or a decentralized fs protocol like IPFS, for now we'll support https protocol only, right?

[adonesky1]

What do you mean by a data URI?

And We currently support fetching data from IPFS in getCollectibleInformationFromTokenURI. I don't see why we shouldn't in this case as well? cc @wachunei

[wachunei]

re ipfs: cool 👍
re data uri: I mean something like data:application/json;base64,ew0KICAgICJ...

[adonesky1]

re data uri: I mean something like data:application/json;base64,ew0KICAgICJ...

ah yes we should have some logic to set this as its own field if the tokenURI is in this format