Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript API does not work from within MetaMask's browser #4621

Open
php4fan opened this issue Jul 3, 2022 · 15 comments
Open

JavaScript API does not work from within MetaMask's browser #4621

php4fan opened this issue Jul 3, 2022 · 15 comments
Assignees
Labels
Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-confirmations-planning (only for internal use within Confirmations team) type-bug Something isn't working WalletConnect WalletConnect related issue or bug

Comments

@php4fan
Copy link

php4fan commented Jul 3, 2022

To Reproduce

  1. Go to Browser
  2. Open this url: https://opentarget.org/test/stupid/mm/trans/
  3. Click on the button that says "Send transaction now"

Expected behavior
Should prompt me to accept or reject the transaction

Observed behavior
Does nothing.
If I haven't connected to the website before, it will show the prompt asking me to connect.
If the current network is not the BNB Smart Chain, it will prompt me to switch to that network.

But after that (or after none of that if that doesn't apply), it does not ask me to confirm the transaction.

Smartphone (please complete the following information):

  • Device: RedMi Note 10S
  • OS: Android 11
  • App Version - 5.2.0 (913)

to be added after bug submission by internal support / PM
Severity

  • How critical is the impact of this bug on a user?
  • Add stats if available on % of customers impacted
  • Is this visible to all users?
  • Is this tech debt?
@php4fan php4fan added the type-bug Something isn't working label Jul 3, 2022
@php4fan
Copy link
Author

php4fan commented Jul 3, 2022

The exact same thing happens when connecting to another device using WalletConnect:

  • the other device shows QR to connect via WalletConnect
  • in the MetaMask app, I scan the code and connect
  • other device requests transaction

then MetaMask does absolutely nothing.

@php4fan
Copy link
Author

php4fan commented Jul 3, 2022

What I described above happens about 95% of the time.

Both in the case of using the in-app browser, and in the case of using another device connected throgh WalletConnect, if I retry several dozen times (e.g. clicking frenetically on the "send transaction" button in the example above, many many times), then about 5% of the times, the prompt to confirm the transaction will show up in MetaMask...

....But then, if I confirm the transaction, I get a stupid error saying "Internal JSON-RPC error".

image

image

@php4fan
Copy link
Author

php4fan commented Jul 9, 2022

No response in 6 days to such a crippling issue??

You'd actually do a better service by not providing an in-app browser at all than providing such a broken one. At least you would't make users waste time trying.

@tommasini tommasini added needs-triage Issues that require triage stability-team labels Jul 12, 2022
@tommasini
Copy link
Contributor

Hey @php4fan , thank you for report, sorry for taking so long to answer.

Answering the issue of opening https://opentarget.org/test/stupid/mm/trans/ and pressing the send transaction, I'm not being able to reproduce it, everything went fine for me with an android device

@php4fan
Copy link
Author

php4fan commented Jul 28, 2022

Can you try with an account that has no funds?

I wonder if this is yet another manifestation of #4646, that is, the fact that when there are not enough funds for the transaction, MetaMask systematically fails to show an error message and just does nothing, immediately closes or just doesn't show up in the first place.

@cortisiko cortisiko added the WalletConnect WalletConnect related issue or bug label Aug 23, 2022
@cortisiko cortisiko removed the needs-triage Issues that require triage label Oct 4, 2022
@tommasini tommasini self-assigned this Oct 6, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Jul 17, 2023
@php4fan
Copy link
Author

php4fan commented Jul 17, 2023

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days.

This is stupid. If no progress is made on an issue for a given amount of time, if anything that's a reason for giving the issue more attention, not for closing it.

@github-actions github-actions bot removed the stale Issues that have not had activity in the last 90 days label Jul 17, 2023
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Oct 15, 2023
@php4fan
Copy link
Author

php4fan commented Oct 17, 2023

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

Once more, please turn off this stupid thing

@github-actions github-actions bot removed the stale Issues that have not had activity in the last 90 days label Oct 17, 2023
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Jan 29, 2024
@php4fan
Copy link
Author

php4fan commented Jan 29, 2024

And again

@github-actions github-actions bot removed the stale Issues that have not had activity in the last 90 days label Jan 29, 2024
@gauthierpetetin gauthierpetetin added team-sdk SDK team team-wallet-api-platform team-confirmations-planning (only for internal use within Confirmations team) labels Feb 1, 2024
@gauthierpetetin gauthierpetetin added team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead team-confirmations-system DEPRECATED: please use "team-confirmations" label instead and removed team-sdk SDK team team-wallet-api-platform team-mobile-client labels Feb 2, 2024
@matthewwalsh0 matthewwalsh0 removed the team-confirmations-system DEPRECATED: please use "team-confirmations" label instead label Feb 5, 2024
@bschorchit bschorchit added Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking and removed team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Feb 7, 2024
Copy link
Contributor

github-actions bot commented May 7, 2024

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label May 7, 2024
@php4fan
Copy link
Author

php4fan commented May 8, 2024

When will you shut down this stupid bot?

To close an issue because no progress has been made in fixing it is completely idiotic.

@github-actions github-actions bot removed the stale Issues that have not had activity in the last 90 days label May 8, 2024
Copy link
Contributor

github-actions bot commented Aug 6, 2024

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Aug 6, 2024
@php4fan
Copy link
Author

php4fan commented Aug 6, 2024

And again.

BTW is this crap still being maintained?

@github-actions github-actions bot removed the stale Issues that have not had activity in the last 90 days label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-confirmations-planning (only for internal use within Confirmations team) type-bug Something isn't working WalletConnect WalletConnect related issue or bug
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

7 participants