-
-
Notifications
You must be signed in to change notification settings - Fork 26
Comparing changes
Open a pull request
base repository: MetaMask/snaps-cli
base: v0.4.2
head repository: MetaMask/snaps-cli
compare: HEAD
- 11 commits
- 45 files changed
- 3 contributors
Commits on Aug 27, 2021
-
Add prepublishOnly script, refactor some other scripts (#123)
Adds a `prepublishOnly` script and standardizes some other package scripts per our module template.
Configuration menu - View commit details
-
Copy full SHA for 231bb8d - Browse repository at this point
Copy the full SHA 231bb8dView commit details
Commits on Sep 6, 2021
-
Lower minimum Node version to 12.11.0 (#125)
This PR lowers the minimum Node version to 12.11.0 in the manifest `engines` field, and sets the version in the `.nvmrc` to `v12`. We increased the minimum Node version to 14 in #77, unfortunately for unknown reasons (`:spiderman-pointing-gif:`). Ideally, we keep it working with all current LTS versions. Since `worker_threads` [first became stable](https://nodejs.org/en/blog/release/v12.11.0/) in 12.11.0, we can't go below that, but that's fine.
Configuration menu - View commit details
-
Copy full SHA for 6d8c5c7 - Browse repository at this point
Copy the full SHA 6d8c5c7View commit details -
Closes #74. This PR adds unit tests for `cli.ts`, and achieves 100% coverage for everything except branches, which are left at 86%. The lower branch coverage is mainly due to solitary `if` statements whose implicit `else` clauses are never tested. In order to achieve the increased test coverage, some internal files have been refactored. All changes should be non-breaking.
Configuration menu - View commit details
-
Copy full SHA for 9571f07 - Browse repository at this point
Copy the full SHA 9571f07View commit details -
Fix development scripts (#129)
The scripts in `development` were previously migrated to TypeScript. They were somewhat broken. This PR makes them plain JavaScript again, and removes them from the build output. This alters the structure of `dist`, which has been taken into account. This also fixes a bug introduced in #126, due to `evalWorker.ts` being renamed to `eval-worker.ts`.
Configuration menu - View commit details
-
Copy full SHA for 187802d - Browse repository at this point
Copy the full SHA 187802dView commit details -
Following #129, updates the TypeScript config to more closely match the MetaMask module template.
Configuration menu - View commit details
-
Copy full SHA for 02f91b8 - Browse repository at this point
Copy the full SHA 02f91b8View commit details -
Bump @metamask/eslint-config from 6.0.0 to 8.0.0 (#117)
* Bump @metamask/eslint-config from 6.0.0 to 8.0.0 Bumps [@metamask/eslint-config](https://github.com/MetaMask/eslint-config) from 6.0.0 to 8.0.0. - [Release notes](https://github.com/MetaMask/eslint-config/releases) - [Commits](MetaMask/eslint-config@v6.0.0...v8.0.0) --- updated-dependencies: - dependency-name: "@metamask/eslint-config" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Manually fix lint issues, simplify config Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Erik Marks <rekmarks@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4365600 - Browse repository at this point
Copy the full SHA 4365600View commit details -
Refactor package exports (#131)
Refactors the package exports (i.e. the exports of the package manifest `main` file, which is `dist/cmds/index`) such that the complete command array is exported under the name `commandModules`, and every individual command handler is exported under its name. The default export is removed.
Configuration menu - View commit details
-
Copy full SHA for 93762e7 - Browse repository at this point
Copy the full SHA 93762e7View commit details -
This PR reverts #131, and completely removes the `main` field from the package manifest. We don't actually want to maintain any contract with consumers regarding our command module exports! The CLI itself is the interface. Packages that want to programmatically invoke `snaps-cli` can use `execa` or the command line.
Configuration menu - View commit details
-
Copy full SHA for 174f13a - Browse repository at this point
Copy the full SHA 174f13aView commit details
Commits on Sep 7, 2021
-
Rename 'development' directory to 'scripts' (#133)
This renames the `./development` directory to `./scripts`, which is more in line with other repositories in our organization.
Configuration menu - View commit details
-
Copy full SHA for 4877594 - Browse repository at this point
Copy the full SHA 4877594View commit details -
Improve mock snap provider (#134)
This PR adds a mock `request` method and all of the `EventEmitter` methods to the mock `wallet` provider object in `eval-worker.ts`. These were previously missing, and made it fail example snaps that should succeed.
Configuration menu - View commit details
-
Copy full SHA for 1d08cea - Browse repository at this point
Copy the full SHA 1d08ceaView commit details
Commits on Sep 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 4411ae2 - Browse repository at this point
Copy the full SHA 4411ae2View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.4.2...HEAD