Skip to content
This repository has been archived by the owner on Sep 9, 2021. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: MetaMask/snaps-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.4.2
Choose a base ref
...
head repository: MetaMask/snaps-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: HEAD
Choose a head ref
  • 11 commits
  • 45 files changed
  • 3 contributors

Commits on Aug 27, 2021

  1. Add prepublishOnly script, refactor some other scripts (#123)

    Adds a `prepublishOnly` script and standardizes some other package scripts per our module template.
    rekmarks committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    231bb8d View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2021

  1. Lower minimum Node version to 12.11.0 (#125)

    This PR lowers the minimum Node version to 12.11.0 in the manifest `engines` field, and sets the version in the `.nvmrc` to `v12`.
    
    We increased the minimum Node version to 14 in #77, unfortunately for unknown reasons (`:spiderman-pointing-gif:`). Ideally, we keep it working with all current LTS versions. Since `worker_threads` [first became stable](https://nodejs.org/en/blog/release/v12.11.0/) in 12.11.0, we can't go below that, but that's fine.
    rekmarks committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    6d8c5c7 View commit details
    Browse the repository at this point in the history
  2. Improve test coverage (#126)

    Closes #74.
    
    This PR adds unit tests for `cli.ts`, and achieves 100% coverage for everything except branches, which are left at 86%. The lower branch coverage is mainly due to solitary `if` statements whose implicit `else` clauses are never tested.
    
    In order to achieve the increased test coverage, some internal files have been refactored. All changes should be non-breaking.
    rekmarks committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    9571f07 View commit details
    Browse the repository at this point in the history
  3. Fix development scripts (#129)

    The scripts in `development` were previously migrated to TypeScript. They were somewhat broken. This PR makes them plain JavaScript again, and removes them from the build output. This alters the structure of `dist`, which has been taken into account.
    
    This also fixes a bug introduced in #126, due to `evalWorker.ts` being renamed to `eval-worker.ts`.
    rekmarks committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    187802d View commit details
    Browse the repository at this point in the history
  4. Update tsconfig.json (#130)

    Following #129, updates the TypeScript config to more closely match the MetaMask module template.
    rekmarks committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    02f91b8 View commit details
    Browse the repository at this point in the history
  5. Bump @metamask/eslint-config from 6.0.0 to 8.0.0 (#117)

    * Bump @metamask/eslint-config from 6.0.0 to 8.0.0
    
    Bumps [@metamask/eslint-config](https://github.com/MetaMask/eslint-config) from 6.0.0 to 8.0.0.
    - [Release notes](https://github.com/MetaMask/eslint-config/releases)
    - [Commits](MetaMask/eslint-config@v6.0.0...v8.0.0)
    
    ---
    updated-dependencies:
    - dependency-name: "@metamask/eslint-config"
      dependency-type: direct:development
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    * Manually fix lint issues, simplify config
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Erik Marks <rekmarks@protonmail.com>
    dependabot[bot] and rekmarks committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    4365600 View commit details
    Browse the repository at this point in the history
  6. Refactor package exports (#131)

    Refactors the package exports (i.e. the exports of the package manifest `main` file, which is `dist/cmds/index`) such that the complete command array is exported under the name `commandModules`, and every individual command handler is exported under its name. The default export is removed.
    rekmarks committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    93762e7 View commit details
    Browse the repository at this point in the history
  7. Remove main export (#132)

    This PR reverts #131, and completely removes the `main` field from the package manifest. We don't actually want to maintain any contract with consumers regarding our command module exports! The CLI itself is the interface. Packages that want to programmatically invoke `snaps-cli` can use `execa` or the command line.
    rekmarks committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    174f13a View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2021

  1. Rename 'development' directory to 'scripts' (#133)

    This renames the `./development` directory to `./scripts`, which is more in line with other repositories in our organization.
    rekmarks committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    4877594 View commit details
    Browse the repository at this point in the history
  2. Improve mock snap provider (#134)

    This PR adds a mock `request` method and all of the `EventEmitter` methods to the mock `wallet` provider object in `eval-worker.ts`. These were previously missing, and made it fail example snaps that should succeed.
    rekmarks committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    1d08cea View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. Configuration menu
    Copy the full SHA
    4411ae2 View commit details
    Browse the repository at this point in the history
Loading