Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: microsoft/go-winio
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.6.0
Choose a base ref
...
head repository: microsoft/go-winio
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.6.1
Choose a head ref
  • 9 commits
  • 26 files changed
  • 4 contributors

Commits on Oct 24, 2022

  1. Soften linter (#264)

    Remove some aggressive linters: `godoc`, `goconst`, `misspel`, `nestif`,
    and `prealloc.
    Also remove `stylecheck` since it is subsumed by `revive`, and
    the later is more configurable.
    
    Allow tests and build stages to continue even if linter fails.
    
    Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
    helsaawy committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    a059ad7 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. Update version, remove deprecated linter (#265)

    `structcheck` is deprecated.
    Update golanci-lint to 1.50.
    
    Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
    helsaawy committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    650a2e4 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. pkg/etw/sample: remove dependency on github.com/sirupsen/logrus (#267)

    It looks like for the purpose of the example "a" logger was needed, so not
    strictly logrus (probably `fmt.Println()` would've worked even).
    
    This patch removes logrus as dependency for the example. The only remaining
    use of logrus in this repository is now in the pkg/etc/etwlogrus package, which
    _does_ need logrus, but (possibly) could become its own module if we want to
    remove logrus as dependency of go-winio itself.
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    cbf4dd9 View commit details
    Browse the repository at this point in the history
  2. update dependencies (#277)

    Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
    helsaawy committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    6a35904 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. Add some basic bind filter functions (#274)

    * Add some basic bind filter functions
    
    This change adds the ability to mount a a single folder or a volume
    inside another folder, using the bind filter API.
    
    While the API allows mounting multiple sources inside a single mount
    point, acting as an overlay, we disable this functionality in the ApplyFileBinding
    function.
    
    Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
    
    * Add some tests
    
    Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
    
    * Move bind filter to different package
    
    Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
    
    * Use string in signature and fix getFinalPath
    
      * Properly close handle in getFinalPath()
      * Use string in function signature. mksyscall generates proper code to
        convert to utf16
      * Enable TestRemoveFileBinding on Windows Server 2019
    
    Windows Server 2019 only exposes 2 function in bindfltapi.dll:
    
      * BfRemoveMapping
      * BfSetupFilter
    
    Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
    
    * Use windows.UTF16ToString to decode string
    
    Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
    
    * Optimize bfGetMappings signature
    
    Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
    
    * Skip unsupported tests on ltsc2019
    
    Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
    
    * Fix typo, add testcase
    
      * Additionally check if we can write to a read-only mount point, not
        just delete from it
      * No need to set FILE_FLAG_OPEN_REPARSE_POINT when opening a file
    
    Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
    
    * Remove extra flags
    
    Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
    
    * Add test to account for symlinks as sources
    
    Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
    
    ---------
    
    Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
    gabriel-samfira committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    dd5de69 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2023

  1. Apply two upstream CL to mkwinsyscall (#278)

    * Apply CL463216: write source to temp file if formatting fails
    
    This change writes the unformatted Go source code to a temp file if
    "format.Source" fails. Print the temp file path to the console to make
    it easy to find. The source code is what causes formatting errors, and
    it can be difficult to diagnose them without this context.
    
    CL link: https://go-review.googlesource.com/c/sys/+/463216
    commit: 4112509618ee88519f899be20efc6882496b57c8
    
    Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
    
    * Apply CL463215: support "." and "-" in DLL name
    
    This change adds "." and "-" support for DLL filenames in "//sys".
    
    Supporting "." requires a change in how mkwinsyscall handles the
    "= <filename>.<function>" syntax. Instead of assuming that only one "."
    can appear in this string, now mkwinsyscall assumes that any additional
    "." belongs to the filename.
    
    Supporting "." also requires changing how Go identifiers are created for
    each DLL. This change also allows mkwinsyscall to support "-". When
    creating a Go identifier, "." and "-" in the DLL filename are replaced
    with "_". Otherwise, mkwinsyscall would produce invalid Go code, causing
    "format.Source" to fail.
    
    CL link: https://go-review.googlesource.com/c/sys/+/463215
    commit: 71da6904945ac440253cb5c132d64712f80ca497
    
    Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
    
    ---------
    
    Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
    helsaawy committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    2a14e68 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. apply ObjectAttributes fix for certain Windows environments (#280)

    Signed-off-by: Robert Carman <robert_carman@rapid7.com>
    rcarman-r7 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    41915dc View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2023

  1. Add fs.ResolvePath to resolve symbolic links (#275)

    * Add `fs.ResolvePath` to resolve symbolic links
    
    `filepath.EvalSymlinks` does not work well on Windows, and can enter
    infinite loops in certain situations and error out.
    Use Win32 API GetFinalPathNameByHandle to handle path resolution.
    
    Implementation based off on: containerd/containerd#5411
    
    Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
    
    * PR: types, documentation
    
    Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
    
    * remove unneded constant groups
    
    Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
    
    * Attempt normalized path first
    
    Update logic to try querying for normalized path initially, then use
    opened path if access is denied.
    
    Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
    
    ---------
    
    Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
    helsaawy committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    b884eb7 View commit details
    Browse the repository at this point in the history
  2. update linter and fix lints (#284)

    Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
    helsaawy committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    070c828 View commit details
    Browse the repository at this point in the history
Loading