Skip to content
This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

Fix Clojure syntax highlighting #38

Merged
merged 13 commits into from
Aug 8, 2018
Merged

Conversation

masad-frost
Copy link
Contributor

@masad-frost masad-frost commented Jun 9, 2018

Fixes some errors in clojure highlighting and added a couple of things.

Also fixed scheme comments being inverted, sorry! 🤦‍♂️

Sorry about the long code style fixes. They're isolated in 2 commits ("Prettier" and "Use tabs").

@masad-frost
Copy link
Contributor Author

masad-frost commented Jun 9, 2018

I think we shouldn't even be treating (comment ...) as comments though, since it's not completely ignored by the VM. The contents have to be readable. Thoughts?

See https://clojuredocs.org/clojure.core/comment

Tests are broken @ comments.

@masad-frost
Copy link
Contributor Author

Did some research and seems like consensus is that you don't do special highlighting for (comment since it needs to be readable like any other function.

@alexandrudima do you wanna take a dabble at this? Github's diff option Hide whitespace changes is probably useful here :)

@alexdima alexdima merged commit a0809e5 into microsoft:master Aug 8, 2018
@alexdima
Copy link
Member

alexdima commented Aug 8, 2018

Looking good! Thanks!

@alexdima alexdima added this to the July 2018 milestone Aug 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants