Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required scopes for GitHub Token to README #18

Open
tdmalone opened this issue Oct 5, 2017 · 3 comments
Open

Add required scopes for GitHub Token to README #18

tdmalone opened this issue Oct 5, 2017 · 3 comments

Comments

@tdmalone
Copy link

tdmalone commented Oct 5, 2017

Hi there,

Thank you for your work on npmpub! New user to publishing on npm here. I was wondering if you could add to the README the scopes that you need for the GITHUB_TOKEN?

@MoOx
Copy link
Owner

MoOx commented Oct 6, 2017

To be honest I am not really sure. You should check this code https://github.com/MoOx/github-release-from-changelog/blob/master/github-release-from-changelog.js.
I am personally using a token with full access but I guess you don't need everything.

@tdmalone
Copy link
Author

Ah no probs. I had a bit of a hunt.. that package uses grizzly which uses a Node.js wrapper for the GitHub API. It looks like only the release endpoint is being called. According to the API docs, users with push access can create a release. According to the scope docs it looks like the repo scope will cover things for public and private repos, and the public_repo scope for public repos only.

So I would guess that is the only scope required, and people could choose whether they want to grant private access or not. I haven't tested this yet, if I have a chance I will do so and then confirm with a pull request to update the README! I suppose I could also do so in github-release-from-changelog & grizzly repos :)

@MoOx
Copy link
Owner

MoOx commented Oct 11, 2017

Great idea! Thanks for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants