Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elmah.io target last in list #117

Closed
ThomasArdal opened this issue Jun 3, 2019 · 5 comments · Fixed by #118
Closed

elmah.io target last in list #117

ThomasArdal opened this issue Jun 3, 2019 · 5 comments · Fixed by #118
Assignees
Labels

Comments

@ThomasArdal
Copy link
Contributor

The new searchable targets list is awesome. But I just noticed that the elmah.io target is last in the "Integrations (Cloud)" list. Personally, I don't care where the target is on the list, but it just looks a bit weird that everything else is sorted alphabetically. I looked in the code and cannot seem to figure out why it's added as the last item. The target is added here, but it doesn't look like the order in this file is used when generating the website.

@304NotModified
Copy link
Member

Hi, that's a bug then. It should be sorted.

@304NotModified
Copy link
Member

I think I know the issue, the _.orderBy(list, function (item) { return item.name }) is behaving akward,

It orders like this: A,B,a,b etc

@304NotModified 304NotModified self-assigned this Jun 3, 2019
@ThomasArdal
Copy link
Contributor Author

I see. A quick fix would, of course, be to rename elmah.io to Elmah.io. I would be a bit unhappy with this solution since the product name is all lowercase.

@304NotModified
Copy link
Member

I think #118 will fix this :)

@304NotModified
Copy link
Member

304NotModified commented Jun 3, 2019

image

🎉

thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants