Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RMP] Set up unit tests for Merlin example notebooks #205

Closed
5 tasks done
jperez999 opened this issue Mar 1, 2022 · 2 comments
Closed
5 tasks done

[RMP] Set up unit tests for Merlin example notebooks #205

jperez999 opened this issue Mar 1, 2022 · 2 comments
Assignees
Milestone

Comments

@jperez999 jperez999 self-assigned this Mar 1, 2022
@karlhigley karlhigley changed the title [Task] Migrate Integration tests to use merlin components [Task] Migrate NVT example notebooks to use Merlin components Apr 12, 2022
@karlhigley karlhigley transferred this issue from NVIDIA-Merlin/NVTabular Apr 12, 2022
@karlhigley karlhigley changed the title [Task] Migrate NVT example notebooks to use Merlin components [RMP] Migrate NVT example notebooks to use Merlin components Apr 12, 2022
@karlhigley karlhigley added this to the Merlin 22.05 milestone Apr 12, 2022
@karlhigley karlhigley changed the title [RMP] Migrate NVT example notebooks to use Merlin components [RMP] Set up comprehensive integration testing for Merlin libraries Apr 12, 2022
@karlhigley karlhigley removed this from the Merlin 22.05 milestone Apr 19, 2022
@karlhigley karlhigley changed the title [RMP] Set up comprehensive integration testing for Merlin libraries [RMP] Set up comprehensive testing for Merlin libraries Apr 20, 2022
@bschifferer
Copy link
Contributor

Migrate the NVT example notebook unit tests to use Testbook

@EvenOldridge @rnyak @mikemckiernan Radek and me talked yesterday, if we need to restructure/move the NVTabular examples. The NVTabular example contains components, which are not relevant anymore (training, deployment). I am not sure, if it make sense to migrate the unittests to testbook, now. I think we should define the new structure, first and add the unittests for the notebooks which will stay and/or add the new unittests in the new repo (where they will move)

@karlhigley karlhigley modified the milestones: Merlin 22.05, Merlin 22.06 Apr 26, 2022
@karlhigley karlhigley changed the title [RMP] Set up comprehensive testing for Merlin libraries [RMP] Set up unit and integration tests for Merlin example notebooks May 2, 2022
@karlhigley karlhigley changed the title [RMP] Set up unit and integration tests for Merlin example notebooks [RMP] Set up unit tests for Merlin example notebooks May 27, 2022
@EvenOldridge
Copy link
Member

Now that the initial unit tests are in place we should come up with a process for adding new ones as examples are added to the libraries. @bschifferer can you work with me and @benfred to define this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants