Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NeMo-Curator installable in non GPU environments #4

Closed
ayushdg opened this issue Mar 19, 2024 · 1 comment
Closed

Make NeMo-Curator installable in non GPU environments #4

ayushdg opened this issue Mar 19, 2024 · 1 comment
Assignees

Comments

@ayushdg
Copy link
Collaborator

ayushdg commented Mar 19, 2024

Right now NeMo-Curator has a mix of both CPU and GPU features. However it requires a cuda GPU to be present since the GPU dependencies are imported during library import and that ends up looking for cuda drivers.

Proposed Solution:

  1. Move GPU accelerated versions of modules to an optional import that is not a requirement during library import.
  2. Create an optional dependency while installing NeMo-Curator (maybe something like nemo-curator[cuda12x] following a similar convention to libraries like spacy/cupy/cuDF etc.
@ayushdg ayushdg self-assigned this Apr 10, 2024
@ayushdg
Copy link
Collaborator Author

ayushdg commented Apr 23, 2024

Completed via #27. pip install . will only install CPU dependencies and return placeholder objects for GPU libraries that throw an error if used. pip install "--extra-index-url https://pypi.nvidia.com ".[cuda12x]" will now pull in the GPU dependencies and relevant packages.

@ayushdg ayushdg closed this as completed Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant