From 9030b133c5770f791da19f6610b9fde1e85a9d50 Mon Sep 17 00:00:00 2001 From: Raza Jafri Date: Fri, 7 Jun 2024 22:44:41 -0700 Subject: [PATCH] Addressing the Spark change of renaming the named parameter (#10992) Signed-off-by: Raza Jafri --- .../spark/sql/rapids/GpuInSubqueryExecSuite.scala | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/tests/src/test/spark330/scala/org/apache/spark/sql/rapids/GpuInSubqueryExecSuite.scala b/tests/src/test/spark330/scala/org/apache/spark/sql/rapids/GpuInSubqueryExecSuite.scala index 82ce1073e13..a606dba0572 100644 --- a/tests/src/test/spark330/scala/org/apache/spark/sql/rapids/GpuInSubqueryExecSuite.scala +++ b/tests/src/test/spark330/scala/org/apache/spark/sql/rapids/GpuInSubqueryExecSuite.scala @@ -65,7 +65,7 @@ class GpuInSubqueryExecSuite extends SparkQueryCompareTestSuite { private def buildCpuInSubqueryPlan( spark: SparkSession, - shouldBroadcast: Boolean): SparkPlan = { + shouldBroadcastOrDpp: Boolean): SparkPlan = { val df1ReadExec = readToPhysicalPlan(nullableStringsIntsDf(spark)) val df2ReadExec = readToPhysicalPlan(subqueryTable(spark)) val inSubquery = InSubqueryExec( @@ -73,16 +73,19 @@ class GpuInSubqueryExecSuite extends SparkQueryCompareTestSuite { SubqueryExec("sbe", ProjectExec(Seq(df2ReadExec.output.head), df2ReadExec)), ExprId(7), - shouldBroadcast=shouldBroadcast) + shouldBroadcastOrDpp) FilterExec(DynamicPruningExpression(inSubquery), df1ReadExec) } - for (shouldBroadcast <- Seq(false, true)) { - test(s"InSubqueryExec shouldBroadcast=$shouldBroadcast") { + /** + * The named parameter shouldBroadcast was renamed to isDynamicPruning in Spark 4.0.0+ + */ + for (shouldBroadcastOrDpp <- Seq(false, true)) { + test(s"InSubqueryExec shouldBroadcastOrDpp=$shouldBroadcastOrDpp") { val gpuResults = withGpuSparkSession({ spark => val overrides = new GpuOverrides() val transitionOverrides = new GpuTransitionOverrides() - val cpuPlan = buildCpuInSubqueryPlan(spark, shouldBroadcast) + val cpuPlan = buildCpuInSubqueryPlan(spark, shouldBroadcastOrDpp) val gpuPlan = transitionOverrides(overrides(cpuPlan)) gpuPlan.execute().collect() })