Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GpuGenerate expressions/generators #10187

Open
abellina opened this issue Jan 11, 2024 · 0 comments
Open

Refactor GpuGenerate expressions/generators #10187

abellina opened this issue Jan 11, 2024 · 0 comments

Comments

@abellina
Copy link
Collaborator

abellina commented Jan 11, 2024

This is a tech debt issue as first mentioned by @revans2 in a PR I put up.

#10131 (comment)_

The request was to move a method inputSplitIndices to the generate expressions themselves. Currently this method is in the GpuGenerator trait.

In general the interface for each trait should be revised, and perhaps split up into other files as well.

We would like to take into account single rows that can explode (for GpuExplode/GpuPosExplode but possibly others) to more than the cuDF column limit, in order to avoid retrying and splitting later: #10131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants