Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Shim layers to support spark versions #1782

Closed
NvTimLiu opened this issue Feb 22, 2021 · 3 comments
Closed

[FEA] Shim layers to support spark versions #1782

NvTimLiu opened this issue Feb 22, 2021 · 3 comments
Labels
feature request New feature or request

Comments

@NvTimLiu
Copy link
Collaborator

NvTimLiu commented Feb 22, 2021

Is your feature request related to a problem? Please describe.

Per issue #1773, after spark-3.0.2 got released, apache-spark3.0 release versions:
3.0.0
3.0.1
3.0.2
Meanwhile, we are building spark snapshot versions:
spark-3.2.0-SNAPSHOT
spark-3.1.2-SNAPSHOT
spark-3.0.3-SNAPSHOT

Currently our rapids-pluging shim layers supported below versions:
• spark300/
• spark300emr/
• spark301/
• spark301db/
• spark301emr/
• spark302/
• spark311/

@sameerz @tgravescs @jlowe @revans2 Could you please help to confirm: our spark-rapids should support all these releases and SNAPSHOT?
If yes, our shim layers need to:
spark302 --> change 3.0.2-SNAPSHOT to 3.0.2
Spark303 --> Add shim layer
spark311 --> upgrade to spark312 SNAPSHOT
spark320 --> It Seems #1704 work for it

scripts need to:
• Change Premerge script to test against latest 3.0.2 release instead of 3.0.1
• Change Nightly script to test against 3.1.2/3.2.0 SNAPSHOT instead of 3.1.1

@NvTimLiu NvTimLiu added feature request New feature or request ? - Needs Triage Need team to review and classify labels Feb 22, 2021
@jlowe
Copy link
Member

jlowe commented Feb 22, 2021

The existing spark302 shims already recognize 3.0.2, so no change is needed there.

A Spark 3.0.3 shim is needed but not in 0.4.

The spark311 shim stays as-is, recognizing both Spark-3.1.1-SNAPSHOT and Spark-3.1.1. No change necessary.

A new spark312 shim is needed but not in 0.4.

Change Nightly script to test against 3.1.2/3.2.0 SNAPSHOT instead of 3.1.1

I don't think we want to drop testing of 3.1.1. These new Spark versions need to be added, not replacing other Spark versions unless we're willing to drop support of those versions.

The spark320 shim will be handled in #1704, again not for 0.4.

@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Feb 23, 2021
@jlowe
Copy link
Member

jlowe commented Mar 1, 2021

Updating the Spark 3.0.2 shim to support the official 3.0.2 release is handled in #1831
Updating the Spark 3.1.1 shim to support the official 3.1.1 release is handled in #1832
The Spark 3.0.3 shim is being added in #1834
The Spark 3.1.2 shim is being added in #1836
The Spark 3.2.0 shim is being added in #1704

Note the new shims are only being added to the nightly "run all the Spark test profiles" portion of the build. No separate pipelines to run the integration tests against these new shims have been created yet.

@sameerz
Copy link
Collaborator

sameerz commented Apr 8, 2021

I believe we have updated all the relevant shim layers for the 0.5 release per this comment:

Updating the Spark 3.0.2 shim to support the official 3.0.2 release is handled in #1831
Updating the Spark 3.1.1 shim to support the official 3.1.1 release is handled in #1832
The Spark 3.0.3 shim is being added in #1834
The Spark 3.1.2 shim is being added in #1836
The Spark 3.2.0 shim is being added in #1704

@sameerz sameerz closed this as completed Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants