Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Use AST for filter in join APIs #2441

Closed
revans2 opened this issue May 18, 2021 · 1 comment · Fixed by #4531
Closed

[FEA] Use AST for filter in join APIs #2441

revans2 opened this issue May 18, 2021 · 1 comment · Fixed by #4531
Assignees
@jlowe
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request P0 Must have for release performance A performance related task/issue

Comments

@revans2
Copy link
Collaborator

revans2 commented May 18, 2021

Is your feature request related to a problem? Please describe.
This is follow on work for #2433 and #2440. The goal is to take the AST join work from CUDF when it is ready and use it. We might want to remove the split check that happens before doing a join if it was not removed as a part of #2440. This is because that check cannot take into account the inequality join parts that can happen, so it will be really inaccurate in those cases, not just the fairly inaccurate that it is now.
@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify performance A performance related task/issue cudf_dependency An issue or PR with this label depends on a new feature in cudf labels May 18, 2021
@revans2 revans2 mentioned this issue May 19, 2021
Closed
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label May 25, 2021
@jlowe jlowe self-assigned this Jan 13, 2022
@jlowe jlowe added the P0 Must have for release label Jan 13, 2022
This was referenced Jan 13, 2022
Merged
Merged
@sameerz
Copy link
Collaborator

sameerz commented Jan 24, 2022

Will move this to 22.04 for the remaining task related to mixed joins for conditional hash semi and anti joins.

@jlowe jlowe closed this as completed Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlowe jlowe

Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request P0 Must have for release performance A performance related task/issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use libcudf mixed joins for conditional hash semi and anti joins jlowe/spark-rapids
3 participants
@jlowe @revans2 @sameerz