Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] TransferRequest request transactions are getting leaked #2893

Closed
abellina opened this issue Jul 9, 2021 · 0 comments · Fixed by #2894
Closed

[BUG] TransferRequest request transactions are getting leaked #2893

abellina opened this issue Jul 9, 2021 · 0 comments · Fixed by #2894
Labels
bug Something isn't working shuffle things that impact the shuffle plugin

Comments

@abellina
Copy link
Collaborator

abellina commented Jul 9, 2021

This affects 21.06 and 21.08.

With this change: #2409, a JVM leak was introduced where TransactionRequest transactions are not closed at the server side. I found this while running things in DEBUG mode for another issue and noticed the logs getting really large.

The leak is not good for long running jobs in general (slowing them down eventually), but it is especially not good if you run in DEBUG mode and don't override this log level to INFO or above:

com.nvidia.spark.rapids.shuffle.ucx.UCXServerConnection

As the "pending" transactions are printed in DEBUG mode.

@abellina abellina added bug Something isn't working ? - Needs Triage Need team to review and classify shuffle things that impact the shuffle plugin labels Jul 9, 2021
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Jul 9, 2021
@sameerz sameerz added this to the July 5 - July 16 milestone Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working shuffle things that impact the shuffle plugin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants