Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qualification tool: Document and automate generation of expected results files #2949

Closed
tgravescs opened this issue Jul 16, 2021 · 1 comment · Fixed by #5869
Closed

Qualification tool: Document and automate generation of expected results files #2949

tgravescs opened this issue Jul 16, 2021 · 1 comment · Fixed by #5869
Assignees
Labels
documentation Improvements or additions to documentation P1 Nice to have for release tools

Comments

@tgravescs
Copy link
Collaborator

tgravescs commented Jul 16, 2021

Is your feature request related to a problem? Please describe.
since the qualification tool checks for certain unsupported features, if we ad support for those features the qualification tests can fail.

We should document how to update those files and perhaps have a way to automatically generate to make it easier for devs. It should not automatically commit as dev should verify changes are ok.

see #2946 (comment) for an example

@tgravescs tgravescs added ? - Needs Triage Need team to review and classify tools labels Jul 16, 2021
@Salonijain27 Salonijain27 added documentation Improvements or additions to documentation and removed ? - Needs Triage Need team to review and classify labels Jul 20, 2021
@viadea viadea added the P1 Nice to have for release label Sep 21, 2021
@amahussein amahussein self-assigned this Jun 17, 2022
@amahussein amahussein assigned amahussein and unassigned amahussein Jun 17, 2022
@tgravescs
Copy link
Collaborator Author

Please note documentation wasn't added with just a script to run it... if we find documentation is needed we will file a followup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation P1 Nice to have for release tools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants