Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Support CollectList/CollectSet on nested input types in GroupBy aggregation #3380

Closed
sperlingxx opened this issue Sep 3, 2021 · 0 comments · Fixed by #3399
Closed

[FEA] Support CollectList/CollectSet on nested input types in GroupBy aggregation #3380

sperlingxx opened this issue Sep 3, 2021 · 0 comments · Fixed by #3399
Assignees
@revans2
Labels
feature request New feature or request

Comments

@sperlingxx
Copy link
Collaborator

sperlingxx commented Sep 3, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
Currently, CollectList/CollectSet with nested input types will fallback to CPU under GroupBy aggregation. It is because ObjectHashAggregateExec doesn't support output types of multi-level nested types in terms of TypeSig. We need to enable and verify this feature.
@sperlingxx sperlingxx added feature request New feature or request ? - Needs Triage Need team to review and classify labels Sep 3, 2021
@sperlingxx sperlingxx self-assigned this Sep 3, 2021
@jlowe jlowe linked a pull request Sep 7, 2021 that will close this issue
Fix collect_list test so it covers nested types properly #3399
Merged
@Salonijain27 Salonijain27 removed the ? - Needs Triage Need team to review and classify label Sep 7, 2021
@sperlingxx sperlingxx assigned revans2 and unassigned sperlingxx Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@revans2 revans2

Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix collect_list test so it covers nested types properly revans2/spark-rapids
3 participants
@revans2 @sperlingxx @Salonijain27