Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Refactor RapidsShuffle managers classes #3624

Closed
gerashegalov opened this issue Sep 23, 2021 · 2 comments · Fixed by #6030
Closed

[FEA] Refactor RapidsShuffle managers classes #3624

gerashegalov opened this issue Sep 23, 2021 · 2 comments · Fixed by #6030
Assignees
@abellina
Labels
task Work required that improves the product but is not user facing tech debt

Comments

@gerashegalov
Copy link
Collaborator

This issue is related to the review comments on #3602

  • There is a redundancy in the RapidsShuffle manager class hierarchy and delegation pattern between
    ProxyRapidsShuffleInternalManagerBase and RapidsShuffleInternalManagerBase .
  • VisibleShuffleManager should potentially be renamed according to its role as a tagging trait
@gerashegalov gerashegalov added feature request New feature or request ? - Needs Triage Need team to review and classify labels Sep 23, 2021
@gerashegalov gerashegalov mentioned this issue Sep 23, 2021
Merged
@abellina
Copy link
Collaborator

I can take this for 21.12, if that's OK @gerashegalov

@gerashegalov
Copy link
Collaborator Author

thank you @abellina

@abellina abellina self-assigned this Sep 23, 2021
@Salonijain27 Salonijain27 removed the ? - Needs Triage Need team to review and classify label Sep 28, 2021
@abellina abellina mentioned this issue Jul 19, 2022
Merged
@pxLi pxLi changed the title Refactor RapidsShuffle managers classes [FEA] Refactor RapidsShuffle managers classes Aug 4, 2022
@sameerz sameerz added task Work required that improves the product but is not user facing and removed feature request New feature or request labels Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abellina abellina

Labels
task Work required that improves the product but is not user facing tech debt
Projects
None yet
Milestone
No milestone
4 participants
@abellina @gerashegalov @sameerz @Salonijain27