Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Decimal 128 Support: Casting #3879

Closed
3 tasks done
revans2 opened this issue Oct 21, 2021 · 1 comment · Fixed by #4172
Closed
3 tasks done

[FEA] Decimal 128 Support: Casting #3879

revans2 opened this issue Oct 21, 2021 · 1 comment · Fixed by #4172
Assignees
@razajafri @kuhushukla
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf P0 Must have for release task Work required that improves the product but is not user facing
Milestone
Dec 13 - Jan 7

Comments

@revans2
Copy link
Collaborator

revans2 commented Oct 21, 2021 •
edited by razajafri
Loading

We need to finish the rest of the casting support for Decimal 128.

Many of these are likely to require some changes to CUDF to be able to fully support them. Casting a string to a Decimal128 might end up being exceptionally difficult as the decimal 64 casting goes through a double first, which can lose some precision compared to a decimal64, but really has problems compared to a decimal 128.
@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify task Work required that improves the product but is not user facing and removed feature request New feature or request labels Oct 21, 2021
@Salonijain27 Salonijain27 added cudf_dependency An issue or PR with this label depends on a new feature in cudf P1 Nice to have for release and removed ? - Needs Triage Need team to review and classify labels Oct 26, 2021
@kuhushukla kuhushukla self-assigned this Oct 27, 2021
@sameerz sameerz added P0 Must have for release and removed P1 Nice to have for release labels Nov 12, 2021
@razajafri razajafri mentioned this issue Nov 19, 2021
Merged
@kuhushukla
Copy link
Collaborator

The first one for nested cast is fixed via #4181

@sameerz sameerz added this to the Nov 30 - Dec 10 milestone Dec 1, 2021
@razajafri razajafri mentioned this issue Dec 3, 2021
Merged
@sameerz sameerz linked a pull request Dec 29, 2021 that will close this issue
Support String to Decimal 128 [databricks] #4172
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@razajafri razajafri

@kuhushukla kuhushukla

Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf P0 Must have for release task Work required that improves the product but is not user facing
Projects
None yet
Milestone
Dec 13 - Jan 7
Development

Successfully merging a pull request may close this issue.

Support String to Decimal 128 [databricks] razajafri/spark-rapids
5 participants
@revans2 @sameerz @razajafri @kuhushukla @Salonijain27