Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Release sql-plugin and udf examples jars #3931

Closed
tgravescs opened this issue Oct 27, 2021 · 3 comments
Closed

[BUG] Release sql-plugin and udf examples jars #3931

tgravescs opened this issue Oct 27, 2021 · 3 comments
Labels
bug Something isn't working build Related to CI / CD or cleanly building

Comments

@tgravescs
Copy link
Collaborator

Describe the bug
If people want to use the RapidsUDF functionality we should be releasing the sql-plugin jar so they can put it as a dependency in their project. Also the udf examples jar shouold be released if people are expected to just use the examples we provide in there.

Also we should have a test that what we release actually works. Perhaps we need to split that into separate issue.

@tgravescs tgravescs added bug Something isn't working ? - Needs Triage Need team to review and classify build Related to CI / CD or cleanly building labels Oct 27, 2021
@jlowe
Copy link
Member

jlowe commented Oct 27, 2021

Is it necessary to release the sql-plugin jar to access RapidsUDF? It is available in the existing RAPIDS Accelerator distribution jar:

$ jar tvf dist/target/rapids-4-spark_2.12-21.10.0-SNAPSHOT.jar | grep RapidsUDF
   207 Wed Oct 27 08:01:46 CDT 2021 com/nvidia/spark/RapidsUDF.class

Personally I'd rather have them depend on and compile against the same jar they're going to use at runtime if possible.

@tgravescs
Copy link
Collaborator Author

that's true, they should be able to use that, we should update our examples then to use it as well to make sure nothing was missed being made public

@jlowe
Copy link
Member

jlowe commented Nov 2, 2021

The udf-examples jar should be published as part of moving it to a separate repo to fix #3971. As for the sql-plugin, I think we agree that doesn't need to be published since it's public APIs should be available via the dist jar and users should depend on that directly.

@jlowe jlowe closed this as completed Nov 2, 2021
@jlowe jlowe removed the ? - Needs Triage Need team to review and classify label Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Related to CI / CD or cleanly building
Projects
None yet
Development

No branches or pull requests

2 participants