Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Support line anchor $ and string anchors \z and \Z in regexp_replace #4425

Closed
andygrove opened this issue Dec 22, 2021 · 0 comments · Fixed by #5491
Closed

[FEA] Support line anchor $ and string anchors \z and \Z in regexp_replace #4425

andygrove opened this issue Dec 22, 2021 · 0 comments · Fixed by #5491
Assignees
@NVnavkumar
Labels
feature request New feature or request

Comments

@andygrove
Copy link
Contributor

andygrove commented Dec 22, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
The string anchor \Z has different behavior between cuDF and Java/Spark when used in regex_replace / replace_re.

  • Java definition: The end of the input but for the final terminator, if any
  • cuDF definition: Matches at the end of the string

The string anchor \z also has different behavior when applied to empty strings.

Once #4424 is merged, we at least fall back to CPU if regexp_replace is called with a pattern containing \z or \Z but we should try and support this on the GPU.

Describe the solution you'd like
Support \z and \Z fully on the GPU.

Describe alternatives you've considered
None.

Additional context
None.
@andygrove andygrove added feature request New feature or request ? - Needs Triage Need team to review and classify labels Dec 22, 2021
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Jan 4, 2022
@andygrove andygrove changed the title [FEA] Support string anchor \Z in regexp_replace [FEA] Support string anchors \z and \Z in regexp_replace Jan 5, 2022
This was referenced Jan 5, 2022
Merged
Open
@NVnavkumar NVnavkumar self-assigned this Apr 29, 2022
@NVnavkumar NVnavkumar changed the title [FEA] Support string anchors \z and \Z in regexp_replace [FEA] Support line anchor $ and string anchors \z and \Z in regexp_replace May 13, 2022
@NVnavkumar NVnavkumar mentioned this issue May 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NVnavkumar NVnavkumar

Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enables $, \z, and \Z in REGEXP_REPLACE on the GPU NVnavkumar/spark-rapids
3 participants
@andygrove @sameerz @NVnavkumar