Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Move udf-examples to spark-rapids-examples #4450

Closed
res-life opened this issue Dec 31, 2021 · 2 comments
Closed

[FEA] Move udf-examples to spark-rapids-examples #4450

res-life opened this issue Dec 31, 2021 · 2 comments
Labels
task Work required that improves the product but is not user facing

Comments

@res-life
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
We cannot fully test the UDF interface is working correctly without an external project. Otherwise we risk tying the udf-examples build to the rapids-4-spark build, and that is very problematic (and triggered the desire to move this out in the first place).

Describe the solution you'd like
Move the main part of udf-examples to spark-rapids-examples.
udf-examples depends on the release dist jar in Central Maven (Note the snapshot jar is not published to Central Maven).
Keep some simple cases in the original udf-examples.
Update the rapids code if necessary, such as:
The udf-examples should only depend on dist, but it transitively depends on the sql-plugin module, and sql-plugin jar is not published to Central Maven, so should find the a way to build a clean dist jar that depends on no other jars.

Describe alternatives you've considered

Additional context
See #3934

@res-life res-life added feature request New feature or request ? - Needs Triage Need team to review and classify labels Dec 31, 2021
@sameerz sameerz added task Work required that improves the product but is not user facing and removed feature request New feature or request ? - Needs Triage Need team to review and classify labels Jan 4, 2022
@jlowe
Copy link
Member

jlowe commented Jan 4, 2022

This is essentially a duplicate of #3971

@res-life
Copy link
Collaborator Author

Close this and keep #3971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Work required that improves the product but is not user facing
Projects
None yet
Development

No branches or pull requests

3 participants