Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Avoid regexp cost in string_split for escaped characters #4685

Closed
andygrove opened this issue Feb 3, 2022 · 0 comments · Fixed by #4854
Closed

[FEA] Avoid regexp cost in string_split for escaped characters #4685

andygrove opened this issue Feb 3, 2022 · 0 comments · Fixed by #4854
Assignees
Labels
performance A performance related task/issue

Comments

@andygrove
Copy link
Contributor

Is your feature request related to a problem? Please describe.
In GpuStringSplit we detect whether the provided pattern is a simple string or a regular expression so that we can call the appropriate cuDF method. There is an optimization that we could implement to avoid the cost of regexp in some cases. For example, given the pattern \. we could transpile to . and use the non-regex cuDF method.

Describe the solution you'd like
As described above.

Describe alternatives you've considered
None

Additional context
N/A

@andygrove andygrove added feature request New feature or request ? - Needs Triage Need team to review and classify labels Feb 3, 2022
@sameerz sameerz added performance A performance related task/issue and removed feature request New feature or request ? - Needs Triage Need team to review and classify labels Feb 8, 2022
@NVnavkumar NVnavkumar self-assigned this Feb 9, 2022
@sameerz sameerz added this to the Feb 14 - Feb 25 milestone Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance A performance related task/issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants