Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Update the premerge and nightly tests after moving the UDF example to external repository #4704

Closed
res-life opened this issue Feb 7, 2022 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@res-life
Copy link
Collaborator

res-life commented Feb 7, 2022

Describe the bug
After this PR NVIDIA/spark-rapids-examples#94 is merged, should update the premerge and nightly tests accordingly.

Seems it's rapids_build-it-UDF-native.

Then we can merge this PR #4619.

Steps to run UDF examples including native tests:

git clone spark-rapids-examples
cd examples/RAPIDS-accelerated-UDFs
mvn clean verify -Pudf-native-examples
@res-life res-life added bug Something isn't working ? - Needs Triage Need team to review and classify labels Feb 7, 2022
@res-life res-life changed the title [BUG] Update the premerge and nightly tests after moved the UDF example to external repository [BUG] Update the premerge and nightly tests after moving the UDF example to external repository Feb 7, 2022
@jlowe
Copy link
Member

jlowe commented Feb 7, 2022

@res-life did you mean to reference #4619 instead of #4408? In either case, the PR that will break the nightly builds should be marked as a draft to prevent it from being accidentally merged even after it is approved until the nightly builds are ready for it to be merged.

@res-life
Copy link
Collaborator Author

res-life commented Feb 8, 2022

Yes, referenced the wrong PR, updated.

@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Feb 8, 2022
@sameerz sameerz added this to the Jan 31 - Feb 11 milestone Feb 8, 2022
@pxLi pxLi assigned NvTimLiu and unassigned pxLi Feb 10, 2022
@NvTimLiu
Copy link
Collaborator

working on the issue

@NvTimLiu
Copy link
Collaborator

Nightly pipeline against the new repo is ready, will remove the udf-examples source from spark-rapids GitHub, and update the old premerge/nightly jobs removing mvn build on udf-examples

@NvTimLiu
Copy link
Collaborator

nightly pipeline created : examples-udf-examples-nightly, examples-udf-examples-native

@res-life
Copy link
Collaborator Author

I've checked the pipelines, all are passed, so close this issue.

@jlowe
Copy link
Member

jlowe commented Feb 22, 2022

I thought the intent of this issue was to update the premerge check of this repository, so that PRs proposed for the spark-rapids repository are tested against the udf-examples tests in the spark-rapids-examples repository. Having separate nightly tests is fine, but it would be nice to not lose the UDF testing in the premerge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants