Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Profiling tool should not sum gettingResultTime #5099

Closed
tgravescs opened this issue Mar 30, 2022 · 0 comments · Fixed by #5202
Closed

[BUG] Profiling tool should not sum gettingResultTime #5099

tgravescs opened this issue Mar 30, 2022 · 0 comments · Fixed by #5202
Assignees
Labels
bug Something isn't working tools

Comments

@tgravescs
Copy link
Collaborator

tgravescs commented Mar 30, 2022

Describe the bug
someone asked me a question about the type of gettingResultTime_sum field in the profiling tool because it was huge.
it looks like we sum this but its actually a wallclock time in spark.

 /**
   * The time when the task started remotely getting the result. Will not be set if the
   * task result was sent immediately when the task finished (as opposed to sending an
   * IndirectTaskResult and later fetching the result from the block manager).
   */
  var gettingResultTime: Long = 0

so we should not be summing this across tasks for stages/jobs aggregation.

@tgravescs tgravescs added bug Something isn't working ? - Needs Triage Need team to review and classify tools labels Mar 30, 2022
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Apr 5, 2022
@sameerz sameerz changed the title [BUG]Profiling tool should not sum gettingResultTime [BUG] Profiling tool should not sum gettingResultTime Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants