Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] GpuFilterExec reports incorrect nullability of output in some cases #525

Closed
andygrove opened this issue Aug 7, 2020 · 0 comments · Fixed by #526
Closed

[BUG] GpuFilterExec reports incorrect nullability of output in some cases #525

andygrove opened this issue Aug 7, 2020 · 0 comments · Fixed by #526
Assignees
Labels
bug Something isn't working

Comments

@andygrove
Copy link
Contributor

Describe the bug
GpuFilterExec contains code to look for IsNotNull predicates and uses that information to modify the output attributes to report that those attributes now have nullability=false. However, this code does not work because it is specifically looking for Spark case classes And (when extracting conjunctive predicates) and IsNotNull and does not recognize the GPU replacements for these expressions.

Steps/Code to reproduce bug
We have no easy way to reproduce this currently and I discovered the issue by chance with an intermittent failue in the TPC-H integration tests when AQE is enabled. I will write unit tests to reproduce it along with the fix.

Expected behavior
Output attributes should be reported with nullability = false if the filter had conjunctive predicates containing an IsNotNull expression for the output attribute.

Environment details (please complete the following information)
N/A

Additional context
N/A

@andygrove andygrove added bug Something isn't working ? - Needs Triage Need team to review and classify labels Aug 7, 2020
@andygrove andygrove added this to the Aug 3 - Aug 14 milestone Aug 7, 2020
@andygrove andygrove self-assigned this Aug 7, 2020
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants